Re: [PATCH 1/5] gpg-interface: check good signature in a reliable way

2013-02-15 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 14.02.2013 18:22: > Michael J Gruber writes: > >> Currently, verify_signed_buffer() only checks the return code of gpg, >> and some callers implement additional unreliable checks for "Good >> signature" in the gpg output meant for the user. >> >> Use the status

Re: [PATCH 1/5] gpg-interface: check good signature in a reliable way

2013-02-14 Thread Junio C Hamano
Michael J Gruber writes: > Currently, verify_signed_buffer() only checks the return code of gpg, > and some callers implement additional unreliable checks for "Good > signature" in the gpg output meant for the user. > > Use the status output instead and parse for a line beinning with > "[GNUPG:]

[PATCH 1/5] gpg-interface: check good signature in a reliable way

2013-02-14 Thread Michael J Gruber
Currently, verify_signed_buffer() only checks the return code of gpg, and some callers implement additional unreliable checks for "Good signature" in the gpg output meant for the user. Use the status output instead and parse for a line beinning with "[GNUPG:] GOODSIG ". This is the only reliable w