Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 12:28 -0800, Junio C Hamano wrote: > Martin Langhoff writes: > > > On Wed, Dec 4, 2013 at 10:46 AM, Krzesimir Nowak > > wrote: > >> On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: > >>> On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak > >>> wrote: > >>> > >>> > S

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Junio C Hamano
Martin Langhoff writes: > On Wed, Dec 4, 2013 at 10:46 AM, Krzesimir Nowak > wrote: >> On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: >>> On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak >>> wrote: >>> >>> > So future reader will know what does it mean without running "perldoc >>> >

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 6:34 PM, Jakub Narębski wrote: > On Wed, Dec 4, 2013 at 4:46 PM, Krzesimir Nowak > wrote: >> On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: >>> On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak >>> wrote: >>> >>> > So future reader will know what does it mean wit

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 4:46 PM, Krzesimir Nowak wrote: > On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: >> On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak >> wrote: >> >> > So future reader will know what does it mean without running "perldoc >> > perlvar". >> >> Hmmm... shouldn't futu

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Martin Langhoff
On Wed, Dec 4, 2013 at 10:46 AM, Krzesimir Nowak wrote: > On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: >> On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak >> wrote: >> >> > So future reader will know what does it mean without running "perldoc >> > perlvar". >> >> Hmmm... shouldn't fut

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: > On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak > wrote: > > > So future reader will know what does it mean without running "perldoc > > perlvar". > > Hmmm... shouldn't future reader know it anyway? It is not that cryptic. > I'd say it

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak wrote: > So future reader will know what does it mean without running "perldoc > perlvar". Hmmm... shouldn't future reader know it anyway? It is not that cryptic. I'd say it is idiomatic Perl. Besides, it is not the only place where we set input

[PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Krzesimir Nowak
So future reader will know what does it mean without running "perldoc perlvar". Signed-off-by: Krzesimir Nowak --- gitweb/gitweb.perl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 68c77f6..ee61f9e 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/