Re: [PATCH 1/5] difftool: Simplify print_tool_help()

2012-07-24 Thread David Aguilar
On Tue, Jul 24, 2012 at 7:40 PM, Junio C Hamano wrote: > David Aguilar writes: > Does this implementation handle that case? I'm sorry, but I haven't had time to apply and test myself. [1]: http://thread.gmane.org/gmane.comp.version-control.git/193233/focus=193925 [

Re: [PATCH 1/5] difftool: Simplify print_tool_help()

2012-07-24 Thread Junio C Hamano
David Aguilar writes: >>> Does this implementation handle that case? I'm sorry, but I haven't >>> had time to apply and test myself. >>> >>> [1]: >>> http://thread.gmane.org/gmane.comp.version-control.git/193233/focus=193925 >>> [2]: http://thread.gmane.org/gmane.comp.version-control.git/194158

Re: [PATCH 1/5] difftool: Simplify print_tool_help()

2012-07-24 Thread David Aguilar
On Tue, Jul 24, 2012 at 6:52 PM, David Aguilar wrote: > On Tue, Jul 24, 2012 at 5:43 AM, Tim Henigan wrote: >> On Sun, Jul 22, 2012 at 11:42 PM, David Aguilar wrote: >>> Eliminate a global variable and File::Find usage by building upon >>> basename() and glob() instead. >> >> glob was used in an

Re: [PATCH 1/5] difftool: Simplify print_tool_help()

2012-07-24 Thread David Aguilar
On Tue, Jul 24, 2012 at 5:43 AM, Tim Henigan wrote: > On Sun, Jul 22, 2012 at 11:42 PM, David Aguilar wrote: >> Eliminate a global variable and File::Find usage by building upon >> basename() and glob() instead. > > glob was used in an early revision of the patch that led to bf73fc2 > (difftool:

Re: [PATCH 1/5] difftool: Simplify print_tool_help()

2012-07-24 Thread Tim Henigan
On Sun, Jul 22, 2012 at 11:42 PM, David Aguilar wrote: > Eliminate a global variable and File::Find usage by building upon > basename() and glob() instead. glob was used in an early revision of the patch that led to bf73fc2 (difftool: print list of valid tools with '--tool-help') as well [1]. How

[PATCH 1/5] difftool: Simplify print_tool_help()

2012-07-22 Thread David Aguilar
Eliminate a global variable and File::Find usage by building upon basename() and glob() instead. Signed-off-by: David Aguilar --- git-difftool.perl | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/git-difftool.perl b/git-difftool.perl index c079854..