Re: [PATCH 1/5] check-ignore: move setup into cmd_check_ignore()

2013-04-11 Thread Jeff King
On Thu, Apr 11, 2013 at 12:05:11PM +0100, Adam Spiers wrote: > On Thu, Apr 11, 2013 at 01:25:53AM -0400, Jeff King wrote: > > On Thu, Apr 11, 2013 at 02:59:31AM +0100, Adam Spiers wrote: > > > -static int check_ignore(const char *prefix, const char **pathspec) > > > +static int check_ignore(struct

Re: [PATCH 1/5] check-ignore: move setup into cmd_check_ignore()

2013-04-11 Thread Adam Spiers
On Thu, Apr 11, 2013 at 01:25:53AM -0400, Jeff King wrote: > On Thu, Apr 11, 2013 at 02:59:31AM +0100, Adam Spiers wrote: > > -static int check_ignore(const char *prefix, const char **pathspec) > > +static int check_ignore(struct path_exclude_check check, > > + const char *prefix,

Re: [PATCH 1/5] check-ignore: move setup into cmd_check_ignore()

2013-04-10 Thread Jeff King
On Thu, Apr 11, 2013 at 02:59:31AM +0100, Adam Spiers wrote: > Initialisation of the dir_struct and path_exclude_check structs was > previously done within check_ignore(). This was acceptable since > check_ignore() was only called once per check-ignore invocation; > however the next commit will c

[PATCH 1/5] check-ignore: move setup into cmd_check_ignore()

2013-04-10 Thread Adam Spiers
Initialisation of the dir_struct and path_exclude_check structs was previously done within check_ignore(). This was acceptable since check_ignore() was only called once per check-ignore invocation; however the next commit will convert it into an inner loop which is called once per line of STDIN wh