Re: [PATCH 1/4] t9903: add tests for git-prompt pcmode

2013-06-24 Thread SZEDER Gábor
On Sat, Jun 22, 2013 at 01:32:38PM -0300, Eduardo D'Avila wrote: > These tests where important to make sure that I wouldn't break anything during > the refactorization. Having them pass before *and* after refactorization > guarantees that nothing was broken (except for some subtle case that might

Re: [PATCH 1/4] t9903: add tests for git-prompt pcmode

2013-06-23 Thread Junio C Hamano
"Eduardo D'Avila" writes: > However, I agree that they became redundant. > > Would it make sense to include a patch that only removes the zsh > tests, after the refactorization? I think that would be a sensible thing to do. In any case, Szeder seems to be giving a good guidance on patches in th

Re: [PATCH 1/4] t9903: add tests for git-prompt pcmode

2013-06-22 Thread Eduardo D'Avila
2013/6/22 SZEDER Gábor : > On Thu, Jun 20, 2013 at 11:25:26PM -0300, Eduardo R. D'Avila wrote: >> git-prompt.sh lacks tests for PROMPT_COMMAND mode. >> >> Add tests for: >> * pcmode prompt without colors >> * pcmode prompt with colors for bash >> * pcmode prompt with colors for zsh >> >> Having the

Re: [PATCH 1/4] t9903: add tests for git-prompt pcmode

2013-06-22 Thread SZEDER Gábor
Hi, On Thu, Jun 20, 2013 at 11:25:26PM -0300, Eduardo R. D'Avila wrote: > git-prompt.sh lacks tests for PROMPT_COMMAND mode. > > Add tests for: > * pcmode prompt without colors > * pcmode prompt with colors for bash > * pcmode prompt with colors for zsh > > Having these tests enables an upcoming

[PATCH 1/4] t9903: add tests for git-prompt pcmode

2013-06-20 Thread Eduardo R. D'Avila
git-prompt.sh lacks tests for PROMPT_COMMAND mode. Add tests for: * pcmode prompt without colors * pcmode prompt with colors for bash * pcmode prompt with colors for zsh Having these tests enables an upcoming refactor in a safe way. Signed-off-by: Eduardo R. D'Avila --- 254 0 t/t9903-