Re: [PATCH 1/4] entry.c: submodule recursing: respect force flag correctly

2017-04-14 Thread Stefan Beller
On Fri, Apr 14, 2017 at 11:28 AM, Jonathan Tan wrote: >> @@ -282,12 +283,11 @@ int checkout_entry(struct cache_entry *ce, >> unlink_or_warn(ce->name); >> >> return submodule_move_head(ce->name, >> -

Re: [PATCH 1/4] entry.c: submodule recursing: respect force flag correctly

2017-04-14 Thread Jonathan Tan
On 04/11/2017 04:49 PM, Stefan Beller wrote: In case of a non-forced worktree update, the submodule movement is tested in a dry run first, such that it doesn't matter if the actual update is done via the force flag. However for correctness, we want to give the flag is specified by the user. All c

Re: [PATCH 1/4] entry.c: submodule recursing: respect force flag correctly

2017-04-12 Thread Philip Oakley
From: "Stefan Beller" In case of a non-forced worktree update, the submodule movement is tested in a dry run first, such that it doesn't matter if the actual update is done via the force flag. However for correctness, we want to give the flag is specified by the user. All callers have been inspe

[PATCH 1/4] entry.c: submodule recursing: respect force flag correctly

2017-04-11 Thread Stefan Beller
In case of a non-forced worktree update, the submodule movement is tested in a dry run first, such that it doesn't matter if the actual update is done via the force flag. However for correctness, we want to give the flag is specified by the user. All callers have been inspected and updated if neede