Re: [PATCH 1/4] diff.c: emit_line_0 to take string instead of first sign

2018-08-13 Thread Stefan Beller
On Mon, Aug 13, 2018 at 4:42 AM Johannes Schindelin wrote: > > +/* > > + * Emits > > + * LF > > + * if they are present. 'first' is a NULL terminated string, > > + * 'second' is a buffer of length 'len'. > > + */ > > That does not make it clear what the role of `first` or `second` is. Coul

Re: [PATCH 1/4] diff.c: emit_line_0 to take string instead of first sign

2018-08-13 Thread Johannes Schindelin
Hi Stefan, On Fri, 10 Aug 2018, Stefan Beller wrote: > By providing a string as the first part of the emission we can extend > it later more easily. Thank you for working on this! > While at it, document emit_line_0. > > [...] > > +/* > + * Emits > + * LF > + * if they are present. 'fi

[PATCH 1/4] diff.c: emit_line_0 to take string instead of first sign

2018-08-10 Thread Stefan Beller
By providing a string as the first part of the emission we can extend it later more easily. While at it, document emit_line_0. Signed-off-by: Stefan Beller --- diff.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/diff.c b/diff.c index af9316c