Re: [PATCH 1/4] completion: add missing terminator in case statement

2014-07-22 Thread Junio C Hamano
John Keeping writes: > On Mon, Jul 21, 2014 at 01:09:13PM -0700, Junio C Hamano wrote: >> Junio C Hamano writes: >> >> > John Keeping writes: >> > >> >> Signed-off-by: John Keeping >> >> --- >> > >> > As these ;; are separators not terminators, this is not strictly >> > necessary. Squashing

Re: [PATCH 1/4] completion: add missing terminator in case statement

2014-07-22 Thread John Keeping
On Mon, Jul 21, 2014 at 01:09:13PM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > John Keeping writes: > > > >> Signed-off-by: John Keeping > >> --- > > > > As these ;; are separators not terminators, this is not strictly > > necessary. Squashing it into a change that adds more ca

Re: [PATCH 1/4] completion: add missing terminator in case statement

2014-07-21 Thread Junio C Hamano
Junio C Hamano writes: > John Keeping writes: > >> Signed-off-by: John Keeping >> --- > > As these ;; are separators not terminators, this is not strictly > necessary. Squashing it into a change that adds more case arms to > this case statement is of course not just good but necessary, > thoug

Re: [PATCH 1/4] completion: add missing terminator in case statement

2014-07-21 Thread Junio C Hamano
John Keeping writes: > Signed-off-by: John Keeping > --- As these ;; are separators not terminators, this is not strictly necessary. Squashing it into a change that adds more case arms to this case statement is of course not just good but necessary, though. > contrib/completion/git-completio

[PATCH 1/4] completion: add missing terminator in case statement

2014-07-19 Thread John Keeping
Signed-off-by: John Keeping --- contrib/completion/git-completion.bash | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 7a6e1d7..d0b2895 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/comp