Re: [PATCH 1/4] built-in rebase: no need to check out `onto` twice

Hi Junio On 03/03/2019 01:35, Junio C Hamano wrote: > Phillip Wood writes: > >> Thanks for explaining, it all makes sense to me now > > It would be necessary to make sure that it all makes sense to all > future readers. Are they patches good enough as-is for that, or do > they need some update

Re: [PATCH 1/4] built-in rebase: no need to check out `onto` twice

Hi Junio, On Sun, 3 Mar 2019, Junio C Hamano wrote: > Phillip Wood writes: > > > Thanks for explaining, it all makes sense to me now > > It would be necessary to make sure that it all makes sense to all > future readers. Are they patches good enough as-is for that, or do > they need some upda

Re: [PATCH 1/4] built-in rebase: no need to check out `onto` twice

Phillip Wood writes: > Thanks for explaining, it all makes sense to me now It would be necessary to make sure that it all makes sense to all future readers. Are they patches good enough as-is for that, or do they need some updates before I take a look at them to pick up?

Re: [PATCH 1/4] built-in rebase: no need to check out `onto` twice

Hi Dscho On 01/03/2019 13:19, Johannes Schindelin wrote: Hi Phillip, On Thu, 28 Feb 2019, Phillip Wood wrote: On 28/02/2019 15:27, Johannes Schindelin via GitGitGadget wrote: From: Johannes Schindelin In the case that the rebase boils down to a fast-forward, the built-in rebase reset the w

Re: [PATCH 1/4] built-in rebase: no need to check out `onto` twice

Hi Phillip, On Thu, 28 Feb 2019, Phillip Wood wrote: > On 28/02/2019 15:27, Johannes Schindelin via GitGitGadget wrote: > > From: Johannes Schindelin > > > > In the case that the rebase boils down to a fast-forward, the built-in > > rebase reset the working tree twice: once to start the rebase

Re: [PATCH 1/4] built-in rebase: no need to check out `onto` twice

Hi Johannes On 28/02/2019 15:27, Johannes Schindelin via GitGitGadget wrote: From: Johannes Schindelin In the case that the rebase boils down to a fast-forward, the built-in rebase reset the working tree twice: once to start the rebase at `onto`, then realizing that the original HEAD was an an

[PATCH 1/4] built-in rebase: no need to check out `onto` twice

From: Johannes Schindelin In the case that the rebase boils down to a fast-forward, the built-in rebase reset the working tree twice: once to start the rebase at `onto`, then realizing that the original HEAD was an ancestor, `reset_head()` was called to update the original ref and to point HEAD b