Re: [PATCH 1/3] submodule: clean up subsititions in script

2018-05-03 Thread Casey Fitzpatrick
Thanks I will amend and re-submit (this time with -v$N, I apologize for creating a confusing mess in everyone's email clients :)) On Wed, May 2, 2018 at 1:59 AM, Junio C Hamano wrote: > Casey Fitzpatrick writes: > >> 'recommend_shallow' and 'jobs' variables do not need quotes (they never >> co

Re: [PATCH 1/3] submodule: clean up subsititions in script

2018-05-01 Thread Junio C Hamano
Casey Fitzpatrick writes: > 'recommend_shallow' and 'jobs' variables do not need quotes (they never > contain > spaces) and do not require any additional prefix, therefore remove the > unnecessary subsitition. The resulting patch is good, but "they never contain spaces" is not a very good ratio

[PATCH 1/3] submodule: clean up subsititions in script

2018-05-01 Thread Casey Fitzpatrick
'recommend_shallow' and 'jobs' variables do not need quotes (they never contain spaces) and do not require any additional prefix, therefore remove the unnecessary subsitition. 'progress' is a boolean value. Treat it like the other boolean values in the script by using a substitution. Signed-off-b

[PATCH 1/3] submodule: clean up subsititions in script

2018-05-01 Thread Casey Fitzpatrick
'recommend_shallow' and 'jobs' variables do not need quotes (they never contain spaces) and do not require any additional prefix, therefore remove the unnecessary subsitition. 'progress' is a boolean value. Treat it like the other boolean values in the script by using a substitution. --- git-subm