Ævar Arnfjörð Bjarmason writes:
> On Tue, Jun 27 2017, Junio C. Hamano jotted:
>
>> I somehow thought that your throwing a pull request at git.git would
>> automatically trigger a Travis test, without you having to wait for
>> me to do anything? Am I misinformed?
>
> It's a PR against sha1collis
On Tue, Jun 27, 2017 at 12:38 PM, Liam R. Howlett
wrote:
> That's not the case. _BIG_ENDIAN is defined but not to a value. I
> believe _BYTE_ORDER is defined as 4321, but _BIG_ENDIAN is just defined.
OK. Thanks.
That sounds pretty much useless in the 21st century, where _BYTE_ORDER might
want
* Junio C Hamano [170627 15:10]:
> Ævar Arnfjörð Bjarmason writes:
>
> > Because in the current code is, abbreviated:
> >
> > #if (defined(_BYTE_ORDER) || defined(__BYTE_ORDER) ||
> > defined(__BYTE_ORDER__))
> > #if /* byte order is bendian */
> > #define SHA1DC_BIGENDIAN
> > #
Ævar Arnfjörð Bjarmason writes:
>>> And since Solaris defines _BYTE_ORDER we never get to checking __sparc,
>>> and in fact the "/* byte order is bendian */" test errors out.
>>> ...
>> Well, if Solaris defines _BYTE_ORDER, doesn't that mean they define
>> two constants _BIG_ENDIAN and _LITTLE_EN
On Tue, Jun 27 2017, Junio C. Hamano jotted:
> Ævar Arnfjörð Bjarmason writes:
>
>> Because in the current code is, abbreviated:
>>
>> #if (defined(_BYTE_ORDER) || defined(__BYTE_ORDER) ||
>> defined(__BYTE_ORDER__))
>> #if /* byte order is bendian */
>> #define SHA1DC_BIGENDIAN
>>
Junio C Hamano writes:
> I wonder if the approach like the following might be cleaner to
> extend as we find other oddball platforms.
>
> #undef __SHA1DC_BYTE_ORDER
> #if defined(_BYTE_ORDER)
> #define __SHA1DC_BYTE_ORDER _BYTE_ORDER
> #elif defined(__BYTE_ORDER)
> #define __S
Ævar Arnfjörð Bjarmason writes:
> Because in the current code is, abbreviated:
>
> #if (defined(_BYTE_ORDER) || defined(__BYTE_ORDER) ||
> defined(__BYTE_ORDER__))
> #if /* byte order is bendian */
> #define SHA1DC_BIGENDIAN
> #endif
> #else
> #if /*some processor tests/*
On Tue, Jun 27 2017, Junio C. Hamano jotted:
> Ævar Arnfjörð Bjarmason writes:
>
+#if defined(__BYTE_ORDER) && defined(__BIG_ENDIAN)
+/*
+ * Should detect Big Endian under glibc.git since 14245eb70e ("entered
+ * into RCS", 1992-11-25). Defined in which will have been
+
Ævar Arnfjörð Bjarmason writes:
>>> +#if defined(__BYTE_ORDER) && defined(__BIG_ENDIAN)
>>> +/*
>>> + * Should detect Big Endian under glibc.git since 14245eb70e ("entered
>>> + * into RCS", 1992-11-25). Defined in which will have been
>>> + * brought in by standard headers. See glibc.git and
>>
On Tue, Jun 27 2017, Junio C. Hamano jotted:
> Ævar Arnfjörð Bjarmason writes:
>
>> On Tue, Jun 27 2017, Junio C. Hamano jotted:
>>
>>> Ævar Arnfjörð Bjarmason writes:
>>>
Update sha1dc from my PR #36[1] which'll hopefully be integrated by
upstream soon.
>>>
>>> Please be careful abo
Ævar Arnfjörð Bjarmason writes:
> On Tue, Jun 27 2017, Junio C. Hamano jotted:
>
>> Ævar Arnfjörð Bjarmason writes:
>>
>>> Update sha1dc from my PR #36[1] which'll hopefully be integrated by
>>> upstream soon.
>>
>> Please be careful about the title of the patch. "log --oneline"
>> does not ev
On Tue, Jun 27 2017, Junio C. Hamano jotted:
> Junio C Hamano writes:
>
>>> +#if (defined(__ARMEB__) || defined(__THUMBEB__) || defined(__AARCH64EB__)
>>> || \
>>> defined(__MIPSEB__) || defined(__MIPSEB) || defined(_MIPSEB) || \
>>> defined(__sparc))
>>> +/*
>>> + * Should define B
On Tue, Jun 27 2017, Junio C. Hamano jotted:
> Junio C Hamano writes:
>
>> Ævar Arnfjörð Bjarmason writes:
>>
>>> +#else /* Not under GCC-alike or glibc or or
>>> */
>>> +
>>> +#ifdef _BIG_ENDIAN
>>> +/*
>>> + * Solaris / illumos defines either _LITTLE_ENDIAN or _BIG_ENDIAN in
>>> + * .
>>
On Tue, Jun 27 2017, Junio C. Hamano jotted:
> Ævar Arnfjörð Bjarmason writes:
>
>> Update sha1dc from my PR #36[1] which'll hopefully be integrated by
>> upstream soon.
>
> Please be careful about the title of the patch. "log --oneline"
> does not even let you tell your readers who calls this
* Junio C Hamano [170627 11:55]:
> Junio C Hamano writes:
>
> >> +#if (defined(__ARMEB__) || defined(__THUMBEB__) || defined(__AARCH64EB__)
> >> || \
> >> defined(__MIPSEB__) || defined(__MIPSEB) || defined(_MIPSEB) || \
> >> defined(__sparc))
> >> +/*
> >> + * Should define Big End
Junio C Hamano writes:
>> +#if (defined(__ARMEB__) || defined(__THUMBEB__) || defined(__AARCH64EB__)
>> || \
>> defined(__MIPSEB__) || defined(__MIPSEB) || defined(_MIPSEB) || \
>> defined(__sparc))
>> +/*
>> + * Should define Big Endian for a whitelist of known processors. See
>> +
Junio C Hamano writes:
> Ævar Arnfjörð Bjarmason writes:
>
>> +#else /* Not under GCC-alike or glibc or or
>> */
>> +
>> +#ifdef _BIG_ENDIAN
>> +/*
>> + * Solaris / illumos defines either _LITTLE_ENDIAN or _BIG_ENDIAN in
>> + * .
>> + */
>> +#define SHA1DC_BIGENDIAN
>
> This makes readers o
Ævar Arnfjörð Bjarmason writes:
> Update sha1dc from my PR #36[1] which'll hopefully be integrated by
> upstream soon.
Please be careful about the title of the patch. "log --oneline"
does not even let you tell your readers who calls this as "my"
change, and readers would be clueless what PR #3
Update sha1dc from my PR #36[1] which'll hopefully be integrated by
upstream soon.
This solves the Big Endian detection on Solaris reported against
v2.13.2[2], hopefully without any regressions.
See commit a0103914c2 ("sha1dc: update from upstream", 2017-05-20) and
6b851e536b ("sha1dc: update fro
19 matches
Mail list logo
