Re: [PATCH 1/3] remote-helpers: fix the run of all tests

2013-04-04 Thread Felipe Contreras
Jeff King wrote: > On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote: > > > On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras > > wrote: > > > +export TEST_LINT := > > > > I think "test-lint-executable" still makes sense here. > > Also test-lint-shell-syntax, which finds a problem

Re: [PATCH 1/3] remote-helpers: fix the run of all tests

2013-04-03 Thread Junio C Hamano
Jeff King writes: > On Tue, Apr 02, 2013 at 06:53:28PM +0200, Torsten Bögershausen wrote: > >> > I think the check for duplicate-numbers is the only one that does not >> > make sense. >> [] >> Not sure about that, I send a suggestion of a patch in a minute. >> Highlights: >> 1) - rename the cont

Re: [PATCH 1/3] remote-helpers: fix the run of all tests

2013-04-02 Thread Torsten Bögershausen
On 02.04.13 19:36, Jeff King wrote: > On Tue, Apr 02, 2013 at 06:53:28PM +0200, Torsten Bögershausen wrote: > >>> I think the check for duplicate-numbers is the only one that does not >>> make sense. >> [] >> Not sure about that, I send a suggestion of a patch in a minute. >> Highlights: >> 1) -

Re: [PATCH 1/3] remote-helpers: fix the run of all tests

2013-04-02 Thread Jeff King
On Tue, Apr 02, 2013 at 06:53:28PM +0200, Torsten Bögershausen wrote: > > I think the check for duplicate-numbers is the only one that does not > > make sense. > [] > Not sure about that, I send a suggestion of a patch in a minute. > Highlights: > 1) - rename the contrib test cases and assigns re

Re: [PATCH 1/3] remote-helpers: fix the run of all tests

2013-04-02 Thread Torsten Bögershausen
On 02.04.13 01:40, Jeff King wrote: > On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote: > >> On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras >> wrote: >>> +export TEST_LINT := >> >> I think "test-lint-executable" still makes sense here. > > Also test-lint-shell-syntax, which fin

Re: [PATCH 1/3] remote-helpers: fix the run of all tests

2013-04-01 Thread Jeff King
On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote: > On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras > wrote: > > +export TEST_LINT := > > I think "test-lint-executable" still makes sense here. Also test-lint-shell-syntax, which finds a problem with the current code: $ cd con

Re: [PATCH 1/3] remote-helpers: fix the run of all tests

2013-04-01 Thread Antoine Pelisse
Hey Felipe, On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras wrote: > +export TEST_LINT := I think "test-lint-executable" still makes sense here. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

[PATCH 1/3] remote-helpers: fix the run of all tests

2013-04-01 Thread Felipe Contreras
Since test-lint doesn't seem to work here, lets disable it. It wouldn't help either way. Signed-off-by: Felipe Contreras --- contrib/remote-helpers/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile index 9a76575..9c18ed