Re: [PATCH 1/3] refs: make sha1 output parameter of refs_resolve_ref_unsafe() optional

2017-09-24 Thread René Scharfe
Am 24.09.2017 um 03:26 schrieb Junio C Hamano: > I wonder if we want a dedicated helper for them (perhaps about a > dozen callers we have that fall into this pattern?) to call for the > exact purpose, implemented as a thin-wrapper around the > resolve_ref_unsafe() function, though. refs_resolve_re

Re: [PATCH 1/3] refs: make sha1 output parameter of refs_resolve_ref_unsafe() optional

2017-09-23 Thread Junio C Hamano
René Scharfe writes: > Allow callers of refs_resolve_ref_unsafe() to pass NULL if they don't > need the resolved hash value. We already allow the same for the flags > parameter. This new leniency is inherited by the various wrappers like > resolve_ref_unsafe(). > > Signed-off-by: Rene Scharfe

[PATCH 1/3] refs: make sha1 output parameter of refs_resolve_ref_unsafe() optional

2017-09-23 Thread René Scharfe
Allow callers of refs_resolve_ref_unsafe() to pass NULL if they don't need the resolved hash value. We already allow the same for the flags parameter. This new leniency is inherited by the various wrappers like resolve_ref_unsafe(). Signed-off-by: Rene Scharfe --- refs.c | 3 +++ refs.h | 9 ++