Re: [PATCH 1/3] object-store: factor out odb_loose_cache()

2019-01-07 Thread René Scharfe
Am 07.01.2019 um 14:26 schrieb René Scharfe: > Yes, the functions are arranged so that odb_load_loose_cache() can be > inlined easily. I meant to include a patch for that but then quibbled > about keeping the BUG check (which is probably optimized out) or not, > and dropped it for now to get the p

Re: [PATCH 1/3] object-store: factor out odb_loose_cache()

2019-01-07 Thread René Scharfe
Am 07.01.2019 um 09:27 schrieb Jeff King: > On Sun, Jan 06, 2019 at 05:45:30PM +0100, René Scharfe wrote: >> diff --git a/object-store.h b/object-store.h >> index 60758efad8..7236c571c0 100644 >> --- a/object-store.h >> +++ b/object-store.h >> @@ -54,6 +54,13 @@ void add_to_alternates_memory(const

Re: [PATCH 1/3] object-store: factor out odb_loose_cache()

2019-01-07 Thread René Scharfe
Am 07.01.2019 um 13:30 schrieb Jeff King: > On Mon, Jan 07, 2019 at 11:27:06AM +, Philip Oakley wrote: > >> On 06/01/2019 16:45, René Scharfe wrote: >>> Add and use a function for loading the entries if a loose object >>> subdirectory for a given object ID. >> >> The second part of the sentenc

Re: [PATCH 1/3] object-store: factor out odb_loose_cache()

2019-01-07 Thread Jeff King
On Mon, Jan 07, 2019 at 11:27:06AM +, Philip Oakley wrote: > On 06/01/2019 16:45, René Scharfe wrote: > > Add and use a function for loading the entries if a loose object > > subdirectory for a given object ID. > > The second part of the sentence 'a loose object subdirectory for a given > obj

Re: [PATCH 1/3] object-store: factor out odb_loose_cache()

2019-01-07 Thread Philip Oakley
On 06/01/2019 16:45, René Scharfe wrote: Add and use a function for loading the entries if a loose object subdirectory for a given object ID. The second part of the sentence 'a loose object subdirectory for a given object ID' does not scan for me. Is there a word missing? It frees caller

Re: [PATCH 1/3] object-store: factor out odb_loose_cache()

2019-01-07 Thread Jeff King
On Sun, Jan 06, 2019 at 05:45:30PM +0100, René Scharfe wrote: > Add and use a function for loading the entries if a loose object > subdirectory for a given object ID. It frees callers from deriving the > fanout key; they can use the returned oid_array reference for lookups or > forward range scan

[PATCH 1/3] object-store: factor out odb_loose_cache()

2019-01-06 Thread René Scharfe
Add and use a function for loading the entries if a loose object subdirectory for a given object ID. It frees callers from deriving the fanout key; they can use the returned oid_array reference for lookups or forward range scans. Suggested-by: Jeff King Signed-off-by: Rene Scharfe --- object-s