Re: [PATCH 1/3] diff-highlight: add some tests.

2016-08-24 Thread Lars Schneider
> On 16 Aug 2016, at 22:48, Junio C Hamano wrote: > > Lars Schneider writes: > >>> On 30 Jul 2016, at 17:11, Brian Henderson wrote: >>> >>> --- >>> contrib/diff-highlight/Makefile | 5 ++ >>> contrib/diff-highlight/t/Makefile| 19 +++ >>> contrib/diff-high

Re: [PATCH 1/3] diff-highlight: add some tests.

2016-08-16 Thread Junio C Hamano
Lars Schneider writes: >> On 30 Jul 2016, at 17:11, Brian Henderson wrote: >> >> --- >> contrib/diff-highlight/Makefile | 5 ++ >> contrib/diff-highlight/t/Makefile| 19 +++ >> contrib/diff-highlight/t/t9400-diff-highlight.sh | 63 ++ >> co

Re: [PATCH 1/3] diff-highlight: add some tests.

2016-08-15 Thread Lars Schneider
> On 30 Jul 2016, at 17:11, Brian Henderson wrote: > > --- > contrib/diff-highlight/Makefile | 5 ++ > contrib/diff-highlight/t/Makefile| 19 +++ > contrib/diff-highlight/t/t9400-diff-highlight.sh | 63 ++ > contrib/diff-highlight/t/test-dif

Re: [PATCH 1/3] diff-highlight: add some tests.

2016-08-15 Thread Brian Henderson
On Wed, Aug 10, 2016 at 08:56:35AM +, Eric Wong wrote: > Typically, we expect a reroll in a few days, and I guess there's > no rush (so you can squash your comment patch in addressing > Junio's concern into 3/3). > > Thanks. thanks, (slowly) working on an update. -- To unsubscribe from thi

Re: [PATCH 1/3] diff-highlight: add some tests.

2016-08-15 Thread Junio C Hamano
Brian Henderson writes: > On Wed, Aug 10, 2016 at 08:56:35AM +, Eric Wong wrote: > > > >> Typically, we expect a reroll in a few days, and I guess there's >> no rush (so you can squash your comment patch in addressing >> Junio's concern into 3/3). >> >> Thanks. > > thanks, (slowly) working

Re: [PATCH 1/3] diff-highlight: add some tests.

2016-08-10 Thread Eric Wong
Brian Henderson wrote: Hi Brian, A few minor portability/style nits below, but contrib/ probably (still?) has laxer rules than the rest of git... I think we still require Signed-off-by lines in contrib, though... > +++ b/contrib/diff-highlight/t/Makefile > @@ -0,0 +1,19 @@ > +-include ../../..

[PATCH 1/3] diff-highlight: add some tests.

2016-07-30 Thread Brian Henderson
--- contrib/diff-highlight/Makefile | 5 ++ contrib/diff-highlight/t/Makefile| 19 +++ contrib/diff-highlight/t/t9400-diff-highlight.sh | 63 ++ contrib/diff-highlight/t/test-diff-highlight.sh | 69 4 files changed