Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-02-20 Thread Torsten Bögershausen
On 2015-02-19 20.40, brian m. carlson wrote: > On Thu, Feb 19, 2015 at 09:54:52AM -0800, Junio C Hamano wrote: >> I can see that you do not agree with the "If we accept it" part >> (where "it" refers to "allowing [...] was a bug.")---past acceptance >> was not a bug for you. Do we talk about the sa

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-02-19 Thread brian m. carlson
On Thu, Feb 19, 2015 at 09:54:52AM -0800, Junio C Hamano wrote: I can see that you do not agree with the "If we accept it" part (where "it" refers to "allowing [...] was a bug.")---past acceptance was not a bug for you. Brian is for that "If we accept it", and sees it as a bug. So let's see wha

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-02-19 Thread Junio C Hamano
Torsten Bögershausen writes: > On 02/18/2015 07:40 PM, Junio C Hamano wrote: >> "brian m. carlson" writes: >> >>> I understand that this used to work, but it probably shouldn't have >>> ever been accepted. It's nonstandard, and if we accept it for ssh, >>> people will want it to work for https,

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-02-19 Thread Torsten Bögershausen
On 02/18/2015 07:40 PM, Junio C Hamano wrote: > "brian m. carlson" writes: > >> On Thu, Jan 22, 2015 at 11:05:29PM +0100, Torsten Bögershausen wrote: >>> We want to support ssh://bmc@2001:470:1f05:79::1/git/bmc/homedir.git/ >>> because e.g. the Git shipped with Debian (1.7.10.4) (and a lot of >>

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-02-18 Thread Junio C Hamano
"brian m. carlson" writes: > On Thu, Jan 22, 2015 at 11:05:29PM +0100, Torsten Bögershausen wrote: >>We want to support ssh://bmc@2001:470:1f05:79::1/git/bmc/homedir.git/ >> because e.g. the Git shipped with Debian (1.7.10.4) (and a lot of >> other installations) supports it. > > I understand t

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-01-22 Thread brian m. carlson
On Thu, Jan 22, 2015 at 11:05:29PM +0100, Torsten Bögershausen wrote: We want to support ssh://bmc@2001:470:1f05:79::1/git/bmc/homedir.git/ because e.g. the Git shipped with Debian (1.7.10.4) (and a lot of other installations) supports it. I understand that this used to work, but it probably

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-01-22 Thread Torsten Bögershausen
On 2015-01-22 21.07, brian m. carlson wrote: > On Mon, Jan 19, 2015 at 06:21:24PM +0100, Torsten Bögershausen wrote: >> When parsing an URL, older Git versions did handle >> URLs like ssh://2001:db8::1/repo.git the same way as >> ssh://[2001:db8::1]/repo.git >> >> Commit 83b058 broke the parsing of

Re: [PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-01-22 Thread brian m. carlson
On Mon, Jan 19, 2015 at 06:21:24PM +0100, Torsten Bögershausen wrote: When parsing an URL, older Git versions did handle URLs like ssh://2001:db8::1/repo.git the same way as ssh://[2001:db8::1]/repo.git Commit 83b058 broke the parsing of IPV6 adresses without "[]": It was written in mind that th

[PATCH 1/3] connect.c: Improve parsing of literal IPV6 addresses

2015-01-19 Thread Torsten Bögershausen
When parsing an URL, older Git versions did handle URLs like ssh://2001:db8::1/repo.git the same way as ssh://[2001:db8::1]/repo.git Commit 83b058 broke the parsing of IPV6 adresses without "[]": It was written in mind that the fist ':' in a URL was the beginning of a port number, while the old co