Re: [PATCH 1/2] wrapper.c: consistently quote filenames in error messages

2017-11-02 Thread Junio C Hamano
Simon Ruderich writes: > On Thu, Nov 02, 2017 at 02:16:52PM +0900, Junio C Hamano wrote: >> Junio C Hamano writes: >>> This patch is incomplete without adjusting a handful of tests to >>> expect the updated messages, no? >> >> I'll squash these in while queuing, but there might be more that I >>

Re: [PATCH 1/2] wrapper.c: consistently quote filenames in error messages

2017-11-02 Thread Simon Ruderich
On Thu, Nov 02, 2017 at 02:16:52PM +0900, Junio C Hamano wrote: > Junio C Hamano writes: >> This patch is incomplete without adjusting a handful of tests to >> expect the updated messages, no? > > I'll squash these in while queuing, but there might be more that I > didn't notice. Sorry, didn't thi

Re: [PATCH 1/2] wrapper.c: consistently quote filenames in error messages

2017-11-01 Thread Junio C Hamano
Junio C Hamano writes: > Simon Ruderich writes: > >> All other error messages in the file use quotes around the file name. >> >> This change removes two translations as "could not write to '%s'" and >> "could not close '%s'" are already translated and these two are the only >> occurrences withou

Re: [PATCH 1/2] wrapper.c: consistently quote filenames in error messages

2017-11-01 Thread Junio C Hamano
Simon Ruderich writes: > All other error messages in the file use quotes around the file name. > > This change removes two translations as "could not write to '%s'" and > "could not close '%s'" are already translated and these two are the only > occurrences without quotes. > > Signed-off-by: Simo

[PATCH 1/2] wrapper.c: consistently quote filenames in error messages

2017-11-01 Thread Simon Ruderich
All other error messages in the file use quotes around the file name. This change removes two translations as "could not write to '%s'" and "could not close '%s'" are already translated and these two are the only occurrences without quotes. Signed-off-by: Simon Ruderich --- wrapper.c | 8 --