Re: [PATCH 1/2] url: do not read past end of buffer

2019-06-04 Thread Matthew DeVore
On Tue, Jun 04, 2019 at 07:00:34AM +0200, René Scharfe wrote: > Am 03.06.19 um 22:45 schrieb Matthew DeVore: > > url_decode_internal could have been tricked into reading past the length > > of the **query buffer if there are fewer than 2 characters after a % (in > > a null-terminated string, % woul

Re: [PATCH 1/2] url: do not read past end of buffer

2019-06-03 Thread René Scharfe
Am 03.06.19 um 22:45 schrieb Matthew DeVore: > url_decode_internal could have been tricked into reading past the length > of the **query buffer if there are fewer than 2 characters after a % (in > a null-terminated string, % would have to be the last character). > Prevent this from happening by che

[PATCH 1/2] url: do not read past end of buffer

2019-06-03 Thread Matthew DeVore
url_decode_internal could have been tricked into reading past the length of the **query buffer if there are fewer than 2 characters after a % (in a null-terminated string, % would have to be the last character). Prevent this from happening by checking len before decoding the % sequence. Signed-off