Re: [PATCH 1/2] trace: add trace_print_string_list_key

2018-09-11 Thread Jeff King
On Mon, Sep 10, 2018 at 08:08:35PM -0700, Stefan Beller wrote: > > So the choice being offered are: > > > > (0) take 2/2 only, keeping zero unused helper. > > (1) take 1/2 only, keeping two unused helpers. > > (2) do nothing, keeping the simple unused helper we had from the > > beginning o

Re: [PATCH 1/2] trace: add trace_print_string_list_key

2018-09-10 Thread Stefan Beller
On Mon, Sep 10, 2018 at 5:52 PM Junio C Hamano wrote: > > Stefan Beller writes: > > >> Of course, even though these are 1/2 and 2/2, only one of them and > >> not both would apply. > > > > Or you could squash them once we reach consensus that both are good. > > Ah, sorry, I completely misread the

Re: [PATCH 1/2] trace: add trace_print_string_list_key

2018-09-10 Thread Junio C Hamano
Stefan Beller writes: >> Of course, even though these are 1/2 and 2/2, only one of them and >> not both would apply. > > Or you could squash them once we reach consensus that both are good. Ah, sorry, I completely misread the first one. I thought that it was extending the implementation of exis

Re: [PATCH 1/2] trace: add trace_print_string_list_key

2018-09-10 Thread Stefan Beller
On Mon, Sep 10, 2018 at 3:32 PM Junio C Hamano wrote: > > Stefan Beller writes: > > > I separated this from the other series, making it into 2 patches: > > This first patch adds tracing for string lists and the next patch that > > removes the unused function from the string list API. > > That way

Re: [PATCH 1/2] trace: add trace_print_string_list_key

2018-09-10 Thread Junio C Hamano
Stefan Beller writes: > I separated this from the other series, making it into 2 patches: > This first patch adds tracing for string lists and the next patch that > removes the unused function from the string list API. > That way we can decide on these two patches separately if needed. Of course

[PATCH 1/2] trace: add trace_print_string_list_key

2018-09-10 Thread Stefan Beller
Similar to trace_strbuf or trace_argv_printf, we might want to output a string list in tracing. Add such a function. Signed-off-by: Stefan Beller --- I separated this from the other series, making it into 2 patches: This first patch adds tracing for string lists and the next patch that removes t