Re: [PATCH 1/2] tests: fix non-portable "${var:-"str"}" construct

2018-08-29 Thread Ann T Ropea
Ævar Arnfjörð Bjarmason writes: > Fix this by removing the redundant quotes. There's no need for them, > and the resulting code works under all the aforementioned shells. This > fixes a regression in c2f1d3989 ("t4013: test new output from diff > --abbrev --raw", 2017-12-03) first released with G

Re: [PATCH 1/2] tests: fix non-portable "${var:-"str"}" construct

2018-08-28 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On both AIX 7200-00-01-1543 and FreeBSD 11.2-RELEASE-p2 the > "${var:-"str"}" syntax means something different than what it does > under the bash or dash shells. > > Both will consider the start of the new unescaped quotes to be a new > argument to test_expect_s

[PATCH 1/2] tests: fix non-portable "${var:-"str"}" construct

2018-08-28 Thread Ævar Arnfjörð Bjarmason
On both AIX 7200-00-01-1543 and FreeBSD 11.2-RELEASE-p2 the "${var:-"str"}" syntax means something different than what it does under the bash or dash shells. Both will consider the start of the new unescaped quotes to be a new argument to test_expect_success, resulting in the following error: