Re: [PATCH 1/2] t5310: correctly remove bitmaps for jgit test

2019-03-15 Thread Jeff King
On Fri, Mar 15, 2019 at 02:25:45PM +0100, SZEDER Gábor wrote: > > Our reader implementation will ignore one of the bitmap files, but it's > > likely non-deterministic which one we will use. We'd prefer the one with > > the more recent timestamp (just because of the way the packed_git list > > is s

Re: [PATCH 1/2] t5310: correctly remove bitmaps for jgit test

2019-03-15 Thread SZEDER Gábor
On Fri, Mar 15, 2019 at 02:22:44AM -0400, Jeff King wrote: > We use "jgit gc" to generate a pack bitmap file, and then make sure our > implementation can read it. To prepare the repo before running jgit, we > try to "rm -f" any existing bitmap files. But we got the path wrong; > we're in a bare rep

[PATCH 1/2] t5310: correctly remove bitmaps for jgit test

2019-03-14 Thread Jeff King
We use "jgit gc" to generate a pack bitmap file, and then make sure our implementation can read it. To prepare the repo before running jgit, we try to "rm -f" any existing bitmap files. But we got the path wrong; we're in a bare repo, so looking in ".git/" finds nothing. Our "rm" doesn't complain b