Re: [PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id

2018-09-06 Thread Junio C Hamano
Stefan Beller writes: > All callers use oid_to_hex to convert the desired oid to a string before > calling submodule_move_head. Defer the conversion to the > submodule_move_head as it will turn out to be useful in a bit. > > Signed-off-by: Stefan Beller > --- > > This is also part of the other s

Re: [PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id

2018-09-05 Thread Jonathan Nieder
Stefan Beller wrote: > Subject: submodule.c: convert submodule_move_head new argument to object id Same nit as in https://public-inbox.org/git/20180905233203.ge120...@aiede.svl.corp.google.com/ applies about wondering which subsystem this is in. [...] > --- a/submodule.c > +++ b/submodule.c > @

[PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id

2018-09-05 Thread Stefan Beller
All callers use oid_to_hex to convert the desired oid to a string before calling submodule_move_head. Defer the conversion to the submodule_move_head as it will turn out to be useful in a bit. Signed-off-by: Stefan Beller --- This is also part of the other series sent out yesterday, https://pub