[PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-24 Thread Ramkumar Ramachandra
Currently, when no (valid) upstream is configured for a branch, you get an error like: $ git show @{u} error: No upstream configured for branch 'upstream-error' error: No upstream configured for branch 'upstream-error' fatal: ambiguous argument '@{u}': unknown revision or path not in the w

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-23 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > If you have to ask why, and cannot answer the question yourself, > then you would not know if such a caller exists. After a code > audit, I know there is no such caller that appends @{u} but if you > were writing a quick-and-dirty caller, I would not be surprised if > you f

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-22 Thread Junio C Hamano
Ramkumar Ramachandra writes: > 2. Callers calling in with programmatic data, and expecting the function >to return and not die(). In this case, why would anyone ever >construct a string containing "@{u}" programmatically in the first >place? If you have to ask why, and cannot answer

[PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-22 Thread Ramkumar Ramachandra
Currently, when no (valid) upstream is configured for a branch, you get an error like: $ git show @{u} error: No upstream configured for branch 'upstream-error' error: No upstream configured for branch 'upstream-error' fatal: ambiguous argument '@{u}': unknown revision or path not in the w

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Junio C Hamano
Ramkumar Ramachandra writes: > "@{u}". What am I missing? You draw the arrow the other way around, that is what made the text confusing. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Ramkumar Ramachandra
Junio C Hamano wrote: >> interpret_branch_name -> interpret_branch_name (recursion) >> -> get_sha1_basic -> get_sha1 [context] (end-user data) >> -> substitute_branch_name -> dwim (end-user data) >> -> strbuf_branchname (callers pass a

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Ramkumar Ramachandra wrote: >> Junio C Hamano wrote: >>> So did you or did you not audit the codepath? >> >> No; I was explaining why I didn't in the first place. Going through it now. > > So, this is what I have: > > interpret_branch_name -> interpret_branch_name

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: > Junio C Hamano wrote: >> So did you or did you not audit the codepath? > > No; I was explaining why I didn't in the first place. Going through it now. So, this is what I have: interpret_branch_name -> interpret_branch_name (recursion) -> get_sh

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Junio C Hamano wrote: >> So did you or did you not audit the codepath? > > No; I was explaining why I didn't in the first place. Going through it now. I did not mean "You must do so or we should discard the patch". I just wanted to make sure the log messages say

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > So did you or did you not audit the codepath? No; I was explaining why I didn't in the first place. Going through it now. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Junio C Hamano wrote: >> Does a failure in interpret-branch-name that issue these error >> messages always followed by die() in the caller? I know you looked >> at the cases you noticed as an end-user (like the above "git show @{u}" >> example), but if some codepat

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > Does a failure in interpret-branch-name that issue these error > messages always followed by die() in the caller? I know you looked > at the cases you noticed as an end-user (like the above "git show @{u}" > example), but if some codepaths did this: > > if (interpre

Re: [PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Currently, when no (valid) upstream is configured for a branch, we get > an error like: > > $ git show @{u} > error: No upstream configured for branch 'upstream-error' > error: No upstream configured for branch 'upstream-error' > fatal: ambiguous argument '@

[PATCH 1/2] sha1_name: fix error message for @{u}

2013-05-21 Thread Ramkumar Ramachandra
Currently, when no (valid) upstream is configured for a branch, we get an error like: $ git show @{u} error: No upstream configured for branch 'upstream-error' error: No upstream configured for branch 'upstream-error' fatal: ambiguous argument '@{u}': unknown revision or path not in the wo