Re: [PATCH 1/2] http: Fix handling of missing CURLPROTO_*

2017-08-20 Thread Jeff King
On Fri, Aug 11, 2017 at 05:30:34PM -0700, Junio C Hamano wrote: > > -#if LIBCURL_VERSION_NUM >= 0x071304 > > +#ifdef CURLPROTO_HTTP > > curl_easy_setopt(result, CURLOPT_REDIR_PROTOCOLS, > > get_curl_allowed_protocols(0)); > > curl_easy_setopt(result, CURLOPT_PROTOCOLS,

Re: [PATCH 1/2] http: Fix handling of missing CURLPROTO_*

2017-08-12 Thread Tom G. Christensen
On 12/08/17 02:30, Junio C Hamano wrote: This may make the code to _compile_, but is it sensible to let the code build and be used by the end users without the "these protocols are safe" filter, I wonder? Git will display a warning at runtime if this is not available but perhaps this warning

Re: [PATCH 1/2] http: Fix handling of missing CURLPROTO_*

2017-08-11 Thread Junio C Hamano
"Tom G. Christensen" writes: > Commit aeae4db1 refactored the handling of the curl protocol restriction > support into a function but failed to add a version check for older > versions of curl that lack CURLPROTO_* support. > This adds the missing check and at the same time converts it to a featu

[PATCH 1/2] http: Fix handling of missing CURLPROTO_*

2017-08-11 Thread Tom G. Christensen
Commit aeae4db1 refactored the handling of the curl protocol restriction support into a function but failed to add a version check for older versions of curl that lack CURLPROTO_* support. This adds the missing check and at the same time converts it to a feature check instead of a version based che