Re: [PATCH 1/2] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-06 Thread Francesco Pretto
Ok, applying the suggested modifications and resending shortly. Thank you, Francesco 2014/1/6 Junio C Hamano : > Junio C Hamano writes: > >> "W. Trevor King" writes: >> >>> On Sun, Jan 05, 2014 at 03:50:48AM +0100, Francesco Pretto wrote: + case "$update_module" in +

Re: [PATCH 1/2] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-06 Thread Junio C Hamano
Junio C Hamano writes: > "W. Trevor King" writes: > >> On Sun, Jan 05, 2014 at 03:50:48AM +0100, Francesco Pretto wrote: >>> + case "$update_module" in >>> + '') >>> + ;; # Unset update mode >>> + checkout | rebase |

Re: [PATCH 1/2] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-06 Thread Junio C Hamano
"W. Trevor King" writes: > On Sun, Jan 05, 2014 at 03:50:48AM +0100, Francesco Pretto wrote: >> +case "$update_module" in >> +'') >> +;; # Unset update mode >> +checkout | rebase | merge | none) >> +

Re: [PATCH 1/2] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-05 Thread W. Trevor King
On Sun, Jan 05, 2014 at 03:50:48AM +0100, Francesco Pretto wrote: > + case "$update_module" in > + '') > + ;; # Unset update mode > + checkout | rebase | merge | none) > + ;; # Known

Re: [PATCH 1/2] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-05 Thread Heiko Voigt
On Sun, Jan 05, 2014 at 03:50:48AM +0100, Francesco Pretto wrote: > According to "Documentation/gitmodules.txt", 'checkout' is a valid > 'submodule..update' command. Also "git-submodule.sh" refers to > it and processes it correctly. Reflect commit 'ac1fbb' to support this > syntax and also validate

[PATCH 1/2] git-submodule.sh: Support 'checkout' as a valid update command

2014-01-04 Thread Francesco Pretto
According to "Documentation/gitmodules.txt", 'checkout' is a valid 'submodule..update' command. Also "git-submodule.sh" refers to it and processes it correctly. Reflect commit 'ac1fbb' to support this syntax and also validates property values during 'update' command, issuing a warning if the value