Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-08-01 Thread Philip Oakley
From: "Stefan Beller" Further, remove duplicated space character. https://en.wikipedia.org/wiki/Sentence_spacing seems like a globally controversial thing. (I assumed it was some sort of local dialect before researching it properly) I personally do not mind one way or another regarding (doubl

Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-08-01 Thread Stefan Beller
On Tue, Aug 1, 2017 at 8:59 AM, Kaartic Sivaraam wrote: > On Mon, 2017-07-31 at 13:23 -0700, Stefan Beller wrote: >> On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam >> wrote: >> > Replace the dashed version of a command with undashed >> > version and quote it. >> >> I like it, but similar as be

[PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-08-01 Thread Kaartic Sivaraam
Replace the dashed version of a command with undashed version and quote it. Use double quotes to quote a git command for consistency. Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/Submitt

Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-08-01 Thread Kaartic Sivaraam
On Mon, 2017-07-31 at 13:23 -0700, Stefan Beller wrote: > On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam > wrote: > > Replace the dashed version of a command with undashed > > version and quote it. > > I like it, but similar as below, we'd want to go for > consistency. > I assume you mean the

Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-31 Thread Junio C Hamano
Stefan Beller writes: >> Further, remove duplicated space character. > > https://en.wikipedia.org/wiki/Sentence_spacing > seems like a globally controversial thing. (I assumed > it was some sort of local dialect before researching > it properly) > > I personally do not mind one way or another reg

Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-31 Thread Stefan Beller
On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam wrote: > Replace the dashed version of a command with undashed > version and quote it. I like it, but similar as below, we'd want to go for consistency. > > Further, remove duplicated space character. https://en.wikipedia.org/wiki/Sentence_spaci

[PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-30 Thread Kaartic Sivaraam
Replace the dashed version of a command with undashed version and quote it. Further, remove duplicated space character. Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/D

Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-30 Thread Kaartic Sivaraam
On Sun, 2017-07-30 at 15:49 +0100, Philip Oakley wrote: > From: "Kaartic Sivaraam" > > minor nit: It's nice, for these single character changes, to give a clue in > the commit message as to what to look for. > > E.g. > > Quote the command, and remove duplicated space character > Fixed it. Wil

Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-30 Thread Philip Oakley
From: "Kaartic Sivaraam" minor nit: It's nice, for these single character changes, to give a clue in the commit message as to what to look for. E.g. Quote the command, and remove duplicated space character -- Philip. Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4

[PATCH 1/2] doc: fix small issues in SubmittingPatches

2017-07-30 Thread Kaartic Sivaraam
Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 558d465b6..9d0dab08d 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation