Re: [PATCH 1/2] completion: refactor __gitcomp related tests

2012-10-30 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 11:45 PM, SZEDER Gábor wrote: > On Mon, Oct 22, 2012 at 03:39:00AM +0200, Felipe Contreras wrote: >> Lots of duplicated code! >> >> No functional changes. > > I'm not sure. > I'm all for removing duplicated application code, but I'm usually more > conservative when it comes

Re: [PATCH 1/2] completion: refactor __gitcomp related tests

2012-10-30 Thread SZEDER Gábor
On Mon, Oct 22, 2012 at 03:39:00AM +0200, Felipe Contreras wrote: > Lots of duplicated code! > > No functional changes. I'm not sure. I'm all for removing duplicated application code, but I'm usually more conservative when it comes to test code. The more logic, the more possibility for bugs in t

[PATCH 1/2] completion: refactor __gitcomp related tests

2012-10-21 Thread Felipe Contreras
Lots of duplicated code! No functional changes. Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 72 --- 1 file changed, 23 insertions(+), 49 deletions(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index cbd0fb6..1c6952