Re: [PATCH 1/2] cat-file: pass expand_data to print_object_or_die

Jeff King writes: > It technically does typo-fix the error message, which I guess is a > functional change. But I didn't count that. :) > > Here it is with the commit message fixes and your reviewed-by. Thanks, both. Will queue, to eventually merge to 'maint'. > > -- >8 -- > Subject: cat-file:

Re: [PATCH 1/2] cat-file: pass expand_data to print_object_or_die

On Wed, Dec 11, 2013 at 12:11:12PM -0800, Jonathan Nieder wrote: > >However, if we pass > > the whole struct, the called function can make more > > intelligent decisions about which fields were actualled > > filled by sha1_object_info. > > Thanks. > > s/ac

Re: [PATCH 1/2] cat-file: pass expand_data to print_object_or_die

Hi, Jeff King wrote: >However, if we pass > the whole struct, the called function can make more > intelligent decisions about which fields were actualled > filled by sha1_object_info. Thanks. s/actualled/actually/, I think. At first I thought this patch

[PATCH 1/2] cat-file: pass expand_data to print_object_or_die

We currently individually pass the sha1, type, and size fields calculated by sha1_object_info. However, if we pass the whole struct, the called function can make more intelligent decisions about which fields were actualled filled by sha1_object_info. As a side effect, we can rename the local varia