Re: [PATCH 1/2] bisect: parse revs before passing them to check_expected_revs()

2014-12-29 Thread Christian Couder
From: Junio C Hamano > Christian Couder writes: > >> When running for example "git bisect bad HEAD" or >> "git bisect good master", the parameter passed to >> "git bisect (bad|good)" has to be parsed into a >> commit hash before checking if it is the expected >> commit or not. > > Hmm, is that

Re: [PATCH 1/2] bisect: parse revs before passing them to check_expected_revs()

2014-12-29 Thread Junio C Hamano
Christian Couder writes: > When running for example "git bisect bad HEAD" or > "git bisect good master", the parameter passed to > "git bisect (bad|good)" has to be parsed into a > commit hash before checking if it is the expected > commit or not. Hmm, is that because you wrote commit object nam

[PATCH 1/2] bisect: parse revs before passing them to check_expected_revs()

2014-12-25 Thread Christian Couder
When running for example "git bisect bad HEAD" or "git bisect good master", the parameter passed to "git bisect (bad|good)" has to be parsed into a commit hash before checking if it is the expected commit or not. We could do that in is_expected_rev() or in check_expected_revs(), but it is already