Re: [PATCH 1/1] stash: fix segmentation fault when files were added with intent

2019-01-23 Thread Johannes Schindelin
Hi Junio, On Tue, 22 Jan 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > > when I want to see whether a given branch is buggy and when I cannot > > simply `git cherry-pick `: > > > > git cherry-pick > > git checkout HEAD^ -- :^/t/ > > Yup. It is easy to just apply the t

Re: [PATCH 1/1] stash: fix segmentation fault when files were added with intent

2019-01-22 Thread Junio C Hamano
Johannes Schindelin writes: > when I want to see whether a given branch is buggy and when I cannot > simply `git cherry-pick `: > > git cherry-pick > git checkout HEAD^ -- :^/t/ Yup. It is easy to just apply the t/ part to grab the test update to see breakage (which I already said

Re: [PATCH 1/1] stash: fix segmentation fault when files were added with intent

2019-01-21 Thread Johannes Schindelin
Hi Junio, On Fri, 18 Jan 2019, Junio C Hamano wrote: > "Matthew Kraai via GitGitGadget" writes: > > > From: Matthew Kraai > > > > After `git add -N `, the index is in a special state. A state for > > which the built-in stash was not prepared, as it failed to initialize > > the `rev` structure

Re: [PATCH 1/1] stash: fix segmentation fault when files were added with intent

2019-01-18 Thread Junio C Hamano
"Matthew Kraai via GitGitGadget" writes: > From: Matthew Kraai > > After `git add -N `, the index is in a special state. A state for > which the built-in stash was not prepared, as it failed to initialize > the `rev` structure in that case before using `&rev.pending`. > > Detailed explanation: I

[PATCH 1/1] stash: fix segmentation fault when files were added with intent

2019-01-18 Thread Matthew Kraai via GitGitGadget
From: Matthew Kraai After `git add -N `, the index is in a special state. A state for which the built-in stash was not prepared, as it failed to initialize the `rev` structure in that case before using `&rev.pending`. Detailed explanation: If `reset_tree()` returns a non-zero value, `stash_worki