Re: [PATCH 1/1] stash: document stash.useBuiltin

2019-05-17 Thread Johannes Schindelin
Hi Junio, On Wed, 15 May 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> See a few nits below, none of which are necessarily worth a re-roll. > > > > Thanks! > > > > Junio, do you agree, do you want to fix it up on your side? > > I think you'd see all of them in what I've pushed

Re: [PATCH 1/1] stash: document stash.useBuiltin

2019-05-15 Thread Junio C Hamano
Johannes Schindelin writes: >> See a few nits below, none of which are necessarily worth a re-roll. > > Thanks! > > Junio, do you agree, do you want to fix it up on your side? I think you'd see all of them in what I've pushed out. >> > +one-off testing you should report the behavior difference

Re: [PATCH 1/1] stash: document stash.useBuiltin

2019-05-15 Thread Johannes Schindelin
Hi Eric, On Tue, 14 May 2019, Eric Sunshine wrote: > On Tue, May 14, 2019 at 5:19 AM Johannes Schindelin via GitGitGadget > wrote: > > The stash.useBuiltin variable introduced in 90a462725e ("stash: > > optionally use the scripted version again", 2019-02-25) was turned on by > > default, but had

Re: [PATCH 1/1] stash: document stash.useBuiltin

2019-05-14 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Thanks for following up on this. LGTM. Yeah, thanks, both.

Re: [PATCH 1/1] stash: document stash.useBuiltin

2019-05-14 Thread Eric Sunshine
On Tue, May 14, 2019 at 5:19 AM Johannes Schindelin via GitGitGadget wrote: > The stash.useBuiltin variable introduced in 90a462725e ("stash: > optionally use the scripted version again", 2019-02-25) was turned on by > default, but had no documentation. > > Let's document it so that users who run

Re: [PATCH 1/1] stash: document stash.useBuiltin

2019-05-14 Thread Ævar Arnfjörð Bjarmason
On Tue, May 14 2019, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > The stash.useBuiltin variable introduced in 90a462725e ("stash: > optionally use the scripted version again", 2019-02-25) was turned on by > default, but had no documentation. > > Let's document it

[PATCH 1/1] stash: document stash.useBuiltin

2019-05-14 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The stash.useBuiltin variable introduced in 90a462725e ("stash: optionally use the scripted version again", 2019-02-25) was turned on by default, but had no documentation. Let's document it so that users who run into any stability issues with the C rewrite know there's