Re: [PATCH 1/1] git-gui (Windows): use git-bash.exe if it is available

2019-10-01 Thread Pratyush Yadav
On 26/09/19 10:46AM, Thomas Klaeger via GitGitGadget wrote: > From: Thomas Klaeger > > Git for Windows 2.x ships with an executable that starts the Git Bash > with all the environment variables and what not properly set up. It is > also adjusted according to the Terminal emulator option chosen wh

Re: [PATCH 1/1] git-gui (Windows): use git-bash.exe if it is available

2019-10-01 Thread Pratyush Yadav
On 30/09/19 12:27PM, Johannes Schindelin wrote: > Hi, > > On Fri, 27 Sep 2019, Pratyush Yadav wrote: > > > On 26/09/19 10:46AM, Thomas Klaeger via GitGitGadget wrote: > > > From: Thomas Klaeger > > > > > > Git for Windows 2.x ships with an executable that starts the Git Bash > > > with all the e

Re: [PATCH 1/1] git-gui (Windows): use git-bash.exe if it is available

2019-09-30 Thread Johannes Sixt
Am 30.09.19 um 12:27 schrieb Johannes Schindelin: > On Fri, 27 Sep 2019, Pratyush Yadav wrote: >>> + if {$cmdLine != $normalized && [file exists $cmdLine]} { >> >> Why the $cmdLine != $normalized? When would they be equal? The string >> substitution should always change $cmdLine. > > Except when

Re: [PATCH 1/1] git-gui (Windows): use git-bash.exe if it is available

2019-09-30 Thread Johannes Schindelin
Hi, On Fri, 27 Sep 2019, Pratyush Yadav wrote: > On 26/09/19 10:46AM, Thomas Klaeger via GitGitGadget wrote: > > From: Thomas Klaeger > > > > Git for Windows 2.x ships with an executable that starts the Git Bash > > with all the environment variables and what not properly set up. It is > > also

Re: [PATCH 1/1] git-gui (Windows): use git-bash.exe if it is available

2019-09-26 Thread Pratyush Yadav
On 26/09/19 10:46AM, Thomas Klaeger via GitGitGadget wrote: > From: Thomas Klaeger > > Git for Windows 2.x ships with an executable that starts the Git Bash > with all the environment variables and what not properly set up. It is > also adjusted according to the Terminal emulator option chosen wh

[PATCH 1/1] git-gui (Windows): use git-bash.exe if it is available

2019-09-26 Thread Thomas Klaeger via GitGitGadget
From: Thomas Klaeger Git for Windows 2.x ships with an executable that starts the Git Bash with all the environment variables and what not properly set up. It is also adjusted according to the Terminal emulator option chosen when installing Git for Windows (while `bash.exe --login -i` would alway