Re: [PATCH 1/1] diff: munmap() file contents before running external diff

2019-07-10 Thread Johannes Schindelin
Hi Junio, On Mon, 8 Jul 2019, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > When running an external diff from, say, a diff tool, it is safe to > > assume that we want to write the files in question. On Windows, that > > means t

Re: [PATCH 1/1] diff: munmap() file contents before running external diff

2019-07-08 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > When running an external diff from, say, a diff tool, it is safe to > assume that we want to write the files in question. On Windows, that > means that there cannot be any other process holding an open handle to > sai

[PATCH 1/1] diff: munmap() file contents before running external diff

2019-07-04 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin When running an external diff from, say, a diff tool, it is safe to assume that we want to write the files in question. On Windows, that means that there cannot be any other process holding an open handle to said files. So let's make sure that `git diff` itself is not h