Re: [PATCH 1/1] configure.ac: Properly check for libintl

2019-04-19 Thread Junio C Hamano
Vadim Kochan writes: >> I think >> >> autoconf: #include when checking for gettext() >> >> is probably a better title. >> >> Together with your originally proposed log message, which we now >> know explains why this inclusion makes a difference sufficiently to >> be understandable by a

Re: [PATCH 1/1] configure.ac: Properly check for libintl

2019-04-19 Thread Vadim Kochan
Hi Junio, On Fri, Apr 19, 2019 at 01:56:48PM +0900, Junio C Hamano wrote: > Vadym Kochan writes: > > >> Some libc implementations have function called gettext() that > >> can be linked via -lc without -lintl, but these are mere stubs > >> and do not do useful i18n. On these systems,

Re: [PATCH 1/1] configure.ac: Properly check for libintl

2019-04-19 Thread Junio C Hamano
Vadym Kochan writes: >> Some libc implementations have function called gettext() that >> can be linked via -lc without -lintl, but these are mere stubs >> and do not do useful i18n. On these systems, if a program that >> calls gettext() is built _with_ "#include ", the >> lin

Re: [PATCH 1/1] configure.ac: Properly check for libintl

2019-04-18 Thread Vadym Kochan
Hi Junio, On Thu, Apr 18, 2019 at 02:45:56PM +0900, Junio C Hamano wrote: > Vadim Kochan writes: > > > Some libc implementations like uclibc or musl provides > > gettext stubs via libintl library but this case is not checked > > by AC_CHECK_LIB(c, gettext ...) because gcc has gettext as builtin

Re: [PATCH 1/1] configure.ac: Properly check for libintl

2019-04-17 Thread Junio C Hamano
Vadim Kochan writes: > Some libc implementations like uclibc or musl provides > gettext stubs via libintl library but this case is not checked > by AC_CHECK_LIB(c, gettext ...) because gcc has gettext as builtin > which passess the check. > > So check it with included libintl.h where gettext may

[PATCH 1/1] configure.ac: Properly check for libintl

2019-04-17 Thread Vadim Kochan
Some libc implementations like uclibc or musl provides gettext stubs via libintl library but this case is not checked by AC_CHECK_LIB(c, gettext ...) because gcc has gettext as builtin which passess the check. So check it with included libintl.h where gettext may unfold into libintl_gettext which