Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-31 Thread Junio C Hamano
Johannes Schindelin writes: > Indeed, the patch in question regards something I consider outside Git for > Windows' realm. As Chris said, you can run this script from a PowerShell > prompt, without any Git Bash (and without Git's Perl) involved. > > I am fine with this patch, as long as the autho

Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-31 Thread Johannes Schindelin
Hi, On Wed, 31 Oct 2018, Junio C Hamano wrote: > > From: chris > > Please make this line read like > > From: Chris Webster > > i.e. the author should be the person who is signing off that patch. This is most likely recorded as the commit's author in the commit object... Chris, to fix

Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-31 Thread Johannes Schindelin
Hi Junio, On Wed, 31 Oct 2018, Junio C Hamano wrote: > Chris Webster writes: > > >>> > Use File::Spec->devnull() for output redirection to avoid messages > >>> > when Windows version of Perl is first in path. The message 'The > >>> > >>> Dscho, "Windows version of Perl is first in path" someho

Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-30 Thread Junio C Hamano
Chris Webster writes: >>> > Use File::Spec->devnull() for output redirection to avoid messages >>> > when Windows version of Perl is first in path. The message 'The >>> >>> Dscho, "Windows version of Perl is first in path" somehow feels >>> contradicting with what one of the topics I saw from yo

Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-30 Thread Chris Webster
Resending in text mode. On Tue, Oct 30, 2018 at 10:20 PM Chris Webster wrote: > > On Tue, Oct 30, 2018 at 9:54 PM Junio C Hamano wrote: >> >> "chris via GitGitGadget" writes: >> >> > From: chris >> > >> > Use File::Spec->devnull() for output redirection to avoid messages >> > when Windows vers

Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-30 Thread Junio C Hamano
> Subject: Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows As this is only about contrib/diff-highlight, please make it clear that it is the area the patch affects on its title, i.e. Subject: diff-highlight: use File::Spec->devnull(), not /dev/null or something lik

Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-30 Thread Junio C Hamano
"chris via GitGitGadget" writes: > From: chris > > Use File::Spec->devnull() for output redirection to avoid messages > when Windows version of Perl is first in path. The message 'The Dscho, "Windows version of Perl is first in path" somehow feels contradicting with what one of the topics I sa

Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-30 Thread Junio C Hamano
Jeff King writes: > On Tue, Oct 30, 2018 at 11:26:36AM -0700, chris via GitGitGadget wrote: > >> From: chris > > You might want to adjust your user.name. :) Yes, absolutely. We'd want to see that the From: line and one of the Signed-off-by: lines are idential. >> Use File::Spec->devnull() for

Re: [PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-30 Thread Jeff King
On Tue, Oct 30, 2018 at 11:26:36AM -0700, chris via GitGitGadget wrote: > From: chris You might want to adjust your user.name. :) > Use File::Spec->devnull() for output redirection to avoid messages > when Windows version of Perl is first in path. The message 'The > system cannot find the path

[PATCH 1/1] Use correct /dev/null for UNIX and Windows

2018-10-30 Thread chris via GitGitGadget
From: chris Use File::Spec->devnull() for output redirection to avoid messages when Windows version of Perl is first in path. The message 'The system cannot find the path specified.' is displayed each time git is run to get colors. Signed-off-by: Chris. Webster --- contrib/diff-highlight/Diff