Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

Hi Junio, On Wed, 10 Jul 2019, Junio C Hamano wrote: > Junio C Hamano writes: > > >> In addition, your `+` scheme will break on Windows once it uses `git.exe` > >> or any other non-MSYS2 helper... > > > > I am not sure what you mean here. Is your git.exe disabled not to > > be able to do this:

Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

Junio C Hamano writes: >> In addition, your `+` scheme will break on Windows once it uses `git.exe` >> or any other non-MSYS2 helper... > > I am not sure what you mean here. Is your git.exe disabled not to > be able to do this: "git.exe add hello+kitty.txt"? I think that is > a more grave probl

Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

Hi Junio, On Tue, 9 Jul 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > > In addition, your `+` scheme will break on Windows once it uses > > `git.exe` or any other non-MSYS2 helper... > > I am not sure what you mean here. Is your git.exe disabled not to > be able to do this: "git

Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

Johannes Schindelin writes: > Using `.lock` is actually an even more established pattern. (I used `.new` > because the intention is not to lock files, but I would be prepared to > change the patch to that end.) When I said that the plus convention is established in this project and not limited t

Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

Hi Junio, On Mon, 8 Jul 2019, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > A `+` is not a valid part of a filename with Windows file systems (it is > > reserved because the `+` operator meant file concatenation back in the > >

Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > A `+` is not a valid part of a filename with Windows file systems (it is > reserved because the `+` operator meant file concatenation back in the > DOS days). The title of the cover letter had "windows" in it, so cal

[PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

From: Johannes Schindelin A `+` is not a valid part of a filename with Windows file systems (it is reserved because the `+` operator meant file concatenation back in the DOS days). When building in Git for Windows' SDK, the `make.exe` that interprets our `Makefile` is an MSYS2 program, which use