Re: [PATCH 09/23] midx: write pack names in chunk

2018-06-22 Thread Derrick Stolee
On 6/22/2018 2:31 PM, Junio C Hamano wrote: Derrick Stolee writes: The index extension documentation doesn't appear to be clear about which extensions are optional or required, but it seems the split-index is the only "required" one and uses lowercase for its extension id. read-cache.c::

Re: [PATCH 09/23] midx: write pack names in chunk

2018-06-22 Thread Junio C Hamano
Derrick Stolee writes: > The index extension documentation doesn't appear to be clear about > which extensions are optional or required, but it seems the > split-index is the only "required" one and uses lowercase for its > extension id. read-cache.c:: /* Index extensions. * * The

Re: [PATCH 09/23] midx: write pack names in chunk

2018-06-22 Thread Derrick Stolee
On 6/21/2018 1:38 PM, Junio C Hamano wrote: Derrick Stolee writes: On 6/7/2018 2:26 PM, Duy Nguyen wrote: On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: @@ -74,6 +80,31 @@ struct midxed_git *load_midxed_git(const char *object_dir) m->num_chunks = *(m->data + 6); m

Re: [PATCH 09/23] midx: write pack names in chunk

2018-06-21 Thread Junio C Hamano
Derrick Stolee writes: > On 6/7/2018 2:26 PM, Duy Nguyen wrote: >> On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: >>> @@ -74,6 +80,31 @@ struct midxed_git *load_midxed_git(const char >>> *object_dir) >>> m->num_chunks = *(m->data + 6); >>> m->num_packs = get_be32(m->dat

Re: [PATCH 09/23] midx: write pack names in chunk

2018-06-21 Thread Derrick Stolee
On 6/7/2018 2:26 PM, Duy Nguyen wrote: On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: @@ -74,6 +80,31 @@ struct midxed_git *load_midxed_git(const char *object_dir) m->num_chunks = *(m->data + 6); m->num_packs = get_be32(m->data + 8); + for (i = 0; i < m->num_chun

Re: [PATCH 09/23] midx: write pack names in chunk

2018-06-07 Thread Duy Nguyen
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: > @@ -74,6 +80,31 @@ struct midxed_git *load_midxed_git(const char *object_dir) > m->num_chunks = *(m->data + 6); > m->num_packs = get_be32(m->data + 8); > > + for (i = 0; i < m->num_chunks; i++) { > + uint32

[PATCH 09/23] midx: write pack names in chunk

2018-06-07 Thread Derrick Stolee
The multi-pack-index (MIDX) needs to track which pack-files are covered by the MIDX file. Store these in our first required chunk. Since filenames are not well structured, add padding to keep good alignment in later chunks. Modify the 'git midx read' subcommand to output the existence of the pack-