Re: [PATCH 08/34] connect: release strbuf on error return in git_connect()

2017-08-31 Thread Stefan Beller
> } else { > + struct strbuf cmd = STRBUF_INIT; > + ... > strbuf_addstr(&cmd, prog); > strbuf_addch(&cmd, ' '); > sq_quote_buf(&cmd, path); ... > if (start_command(conn)) > die("unable to

[PATCH 08/34] connect: release strbuf on error return in git_connect()

2017-08-30 Thread Rene Scharfe
Reduce the scope of the variable cmd and release it before returning early. Signed-off-by: Rene Scharfe --- connect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/connect.c b/connect.c index 49b28b83be..df56c0cbff 100644 --- a/connect.c +++ b/connect.c @@ -775,146 +775,

[PATCH 08/34] connect: release strbuf on error return in git_connect()

2017-08-30 Thread Rene Scharfe
Reduce the scope of the variable cmd and release it before returning early. Signed-off-by: Rene Scharfe --- connect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/connect.c b/connect.c index 49b28b83be..df56c0cbff 100644 --- a/connect.c +++ b/connect.c @@ -775,146 +775,

[PATCH 08/34] connect: release strbuf on error return in git_connect()

2017-08-30 Thread Rene Scharfe
Reduce the scope of the variable cmd and release it before returning early. Signed-off-by: Rene Scharfe --- connect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/connect.c b/connect.c index 49b28b83be..df56c0cbff 100644 --- a/connect.c +++ b/connect.c @@ -775,146 +775,

[PATCH 08/34] connect: release strbuf on error return in git_connect()

2017-08-30 Thread Rene Scharfe
Reduce the scope of the variable cmd and release it before returning early. Signed-off-by: Rene Scharfe --- connect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/connect.c b/connect.c index 49b28b83be..df56c0cbff 100644 --- a/connect.c +++ b/connect.c @@ -775,146 +775,