Re: [PATCH 08/15] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-03-09 Thread Karthik Nayak
On Wed, Mar 9, 2016 at 1:49 AM, Junio C Hamano wrote: > Karthik Nayak writes: > >> On Tue, Mar 8, 2016 at 7:26 AM, Jacob Keller wrote: >>> On Mon, Mar 7, 2016 at 3:08 PM, Junio C Hamano wrote: Karthik Nayak writes: > The "%(symref)" atom doesn't work when used with the ':short' m

Re: [PATCH 08/15] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-03-08 Thread Junio C Hamano
Karthik Nayak writes: > On Tue, Mar 8, 2016 at 7:26 AM, Jacob Keller wrote: >> On Mon, Mar 7, 2016 at 3:08 PM, Junio C Hamano wrote: >>> Karthik Nayak writes: >>> The "%(symref)" atom doesn't work when used with the ':short' modifier because we strictly match only 'symref' for settin

Re: [PATCH 08/15] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-03-07 Thread Karthik Nayak
On Tue, Mar 8, 2016 at 7:26 AM, Jacob Keller wrote: > On Mon, Mar 7, 2016 at 3:08 PM, Junio C Hamano wrote: >> Karthik Nayak writes: >> >>> The "%(symref)" atom doesn't work when used with the ':short' modifier >>> because we strictly match only 'symref' for setting the 'need_symref' >>> indicat

Re: [PATCH 08/15] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-03-07 Thread Jacob Keller
On Mon, Mar 7, 2016 at 3:08 PM, Junio C Hamano wrote: > Karthik Nayak writes: > >> The "%(symref)" atom doesn't work when used with the ':short' modifier >> because we strictly match only 'symref' for setting the 'need_symref' >> indicator. Fix this by using 'starts_with()' rather than 'strcmp()'

Re: [PATCH 08/15] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-03-07 Thread Junio C Hamano
Karthik Nayak writes: > The "%(symref)" atom doesn't work when used with the ':short' modifier > because we strictly match only 'symref' for setting the 'need_symref' > indicator. Fix this by using 'starts_with()' rather than 'strcmp()'. Does that mean you also accept %(symrefgarbage) without co

[PATCH 08/15] ref-filter: make "%(symref)" atom work with the ':short' modifier

2016-03-06 Thread Karthik Nayak
The "%(symref)" atom doesn't work when used with the ':short' modifier because we strictly match only 'symref' for setting the 'need_symref' indicator. Fix this by using 'starts_with()' rather than 'strcmp()'. Add tests for %(symref) and %(symref:short) while we're here. Signed-off-by: Karthik Na