Re: [PATCH 07/26] connect: convert get_remote_heads to use struct packet_reader

2018-01-09 Thread Brandon Williams
On 01/09, Jonathan Tan wrote: > On Tue, 2 Jan 2018 16:18:09 -0800 > Brandon Williams wrote: > > > - while ((len = read_remote_ref(in, &src_buf, &src_len, &responded))) { > > + while (state != EXPECTING_DONE) { > > + switch (packet_reader_read(&reader)) { > > + case PACKET

Re: [PATCH 07/26] connect: convert get_remote_heads to use struct packet_reader

2018-01-09 Thread Jonathan Tan
On Tue, 2 Jan 2018 16:18:09 -0800 Brandon Williams wrote: > - while ((len = read_remote_ref(in, &src_buf, &src_len, &responded))) { > + while (state != EXPECTING_DONE) { > + switch (packet_reader_read(&reader)) { > + case PACKET_READ_EOF: > + d

[PATCH 07/26] connect: convert get_remote_heads to use struct packet_reader

2018-01-02 Thread Brandon Williams
In order to allow for better control flow when protocol_v2 is introduced convert 'get_remote_heads()' to use 'struct packet_reader' to read packet lines. This enables a client to be able to peek the first line of a server's response (without consuming it) in order to determine the protocol version