>
>> Is there anything I can do to help? I'm happy to test out changes.
>
> The patch at the end of his mail obviously passes the newly-added tests
> for me, but please confirm that it fixes your test suite.
>
> I gather your suite is about noticing behavior changes between different
> versions. Fo
On Mon, Nov 07, 2016 at 05:12:43PM -0800, Bryan Turner wrote:
> > The obvious solution is one of:
> >
> > 1. Stop calling normalize() at all when we do not have a relative base
> > and the path is not absolute. This restores the original quirky
> > behavior (plus makes the "foo/../../b
On Mon, Nov 7, 2016 at 4:30 PM, Jeff King wrote:
> On Mon, Nov 07, 2016 at 03:42:35PM -0800, Bryan Turner wrote:
>
>> > @@ -335,7 +340,9 @@ static void link_alt_odb_entries(const char *alt, int
>> > len, int sep,
>> > }
>> >
>> > strbuf_add_absolute_path(&objdirbuf, get_object_dir
On Mon, Nov 07, 2016 at 03:42:35PM -0800, Bryan Turner wrote:
> > @@ -335,7 +340,9 @@ static void link_alt_odb_entries(const char *alt, int
> > len, int sep,
> > }
> >
> > strbuf_add_absolute_path(&objdirbuf, get_object_directory());
> > - normalize_path_copy(objdirbuf.buf,
On Mon, Oct 3, 2016 at 1:34 PM, Jeff King wrote:
> When we add a new alternate to the list, we try to normalize
> out any redundant "..", etc. However, we do not look at the
> return value of normalize_path_copy(), and will happily
> continue with a path that could not be normalized. Worse,
> the
On Wed, Oct 05, 2016 at 08:47:29PM +0200, René Scharfe wrote:
> > Instead, let's provide a strbuf helper that does an in-place
> > normalize, but restores the original contents on error. This
> > uses a second buffer under the hood, which is slightly less
> > efficient, but this is not a performan
Am 03.10.2016 um 22:34 schrieb Jeff King:
When we add a new alternate to the list, we try to normalize
out any redundant "..", etc. However, we do not look at the
return value of normalize_path_copy(), and will happily
continue with a path that could not be normalized. Worse,
the normalizing proc
Jeff King writes:
> +int strbuf_normalize_path(struct strbuf *src)
> +{
> + struct strbuf dst = STRBUF_INIT;
> +
> + strbuf_grow(&dst, src->len);
> + if (normalize_path_copy(dst.buf, src->buf) < 0) {
> + strbuf_release(&dst);
> + return -1;
> + }
> +
> +
On Mon, Oct 3, 2016 at 1:34 PM, Jeff King wrote:
> When we add a new alternate to the list, we try to normalize
> out any redundant "..", etc. However, we do not look at the
> return value of normalize_path_copy(), and will happily
> continue with a path that could not be normalized. Worse,
> the
When we add a new alternate to the list, we try to normalize
out any redundant "..", etc. However, we do not look at the
return value of normalize_path_copy(), and will happily
continue with a path that could not be normalized. Worse,
the normalizing process is done in-place, so we are left
with wh
10 matches
Mail list logo
