Re: [PATCH 07/18] avoid using fixed PATH_MAX buffers for refs

2017-04-17 Thread Junio C Hamano
Jeff King writes: > On Sun, Apr 16, 2017 at 11:00:25PM -0700, Junio C Hamano wrote: > >> > diff --git a/builtin/replace.c b/builtin/replace.c >> > index f83e7b8fc..065515bab 100644 >> > --- a/builtin/replace.c >> > +++ b/builtin/replace.c >> > @@ -93,26 +93,31 @@ typedef int (*each_replace_name_f

Re: [PATCH 07/18] avoid using fixed PATH_MAX buffers for refs

2017-04-17 Thread Jeff King
On Sun, Apr 16, 2017 at 11:00:25PM -0700, Junio C Hamano wrote: > > diff --git a/builtin/replace.c b/builtin/replace.c > > index f83e7b8fc..065515bab 100644 > > --- a/builtin/replace.c > > +++ b/builtin/replace.c > > @@ -93,26 +93,31 @@ typedef int (*each_replace_name_fn)(const char *name, > > co

Re: [PATCH 07/18] avoid using fixed PATH_MAX buffers for refs

2017-04-16 Thread Junio C Hamano
Jeff King writes: > diff --git a/builtin/replace.c b/builtin/replace.c > index f83e7b8fc..065515bab 100644 > --- a/builtin/replace.c > +++ b/builtin/replace.c > @@ -93,26 +93,31 @@ typedef int (*each_replace_name_fn)(const char *name, > const char *ref, > static int for_each_replace_name(const

[PATCH 07/18] avoid using fixed PATH_MAX buffers for refs

2017-03-28 Thread Jeff King
Many functions which handle refs use a PATH_MAX-sized buffer to do so. This is mostly reasonable as we have to write loose refs into the filesystem, and at least on Linux the 4K PATH_MAX is big enough that nobody would care. But: 1. The static PATH_MAX is not always the filesystem limit. 2. O