Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-11 Thread Junio C Hamano
"brian m. carlson" writes: > On Tue, Jul 10, 2018 at 02:08:28PM -0400, Ben Peart wrote: >> >> >> On 7/9/2018 7:39 PM, brian m. carlson wrote: >> > On Mon, Jul 09, 2018 at 10:45:33AM -0700, Junio C Hamano wrote: >> > > As Brandon alludes to downthread, we probably should use strbuf for >> > > th

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-10 Thread brian m. carlson
On Tue, Jul 10, 2018 at 02:08:28PM -0400, Ben Peart wrote: > > > On 7/9/2018 7:39 PM, brian m. carlson wrote: > > On Mon, Jul 09, 2018 at 10:45:33AM -0700, Junio C Hamano wrote: > > > As Brandon alludes to downthread, we probably should use strbuf for > > > things like this these days, so a preli

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-10 Thread Ben Peart
On 7/9/2018 7:39 PM, brian m. carlson wrote: On Mon, Jul 09, 2018 at 10:45:33AM -0700, Junio C Hamano wrote: Derrick Stolee writes: On 7/8/2018 7:36 PM, brian m. carlson wrote: diff --git a/refs/files-backend.c b/refs/files-backend.c index a9a066dcfb..252f835bae 100644 --- a/refs/files-ba

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-10 Thread Junio C Hamano
"brian m. carlson" writes: >> As Brandon alludes to downthread, we probably should use strbuf for >> things like this these days, so a preliminary clean-up to do so is >> probably a welcome change to sneak in and rebase this series on top >> of. > > Sure, I agree that would be a better change, an

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-09 Thread brian m. carlson
On Mon, Jul 09, 2018 at 10:45:33AM -0700, Junio C Hamano wrote: > Derrick Stolee writes: > > > On 7/8/2018 7:36 PM, brian m. carlson wrote: > >> diff --git a/refs/files-backend.c b/refs/files-backend.c > >> index a9a066dcfb..252f835bae 100644 > >> --- a/refs/files-backend.c > >> +++ b/refs/files-

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-09 Thread Junio C Hamano
Derrick Stolee writes: > On 7/8/2018 7:36 PM, brian m. carlson wrote: >> 100 bytes is not sufficient to ensure we can write a commit message >> buffer when using a 32-byte hash algorithm. Increase the buffer size to >> ensure we have sufficient space. >> >> Signed-off-by: brian m. carlson >> --

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-09 Thread Brandon Williams
On 07/09, Junio C Hamano wrote: > Brandon Williams writes: > > >> > > diff --git a/refs/files-backend.c b/refs/files-backend.c > >> > > index a9a066dcfb..252f835bae 100644 > >> > > --- a/refs/files-backend.c > >> > > +++ b/refs/files-backend.c > >> > > @@ -1587,7 +1587,7 @@ static int log_ref_wri

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-09 Thread Junio C Hamano
Brandon Williams writes: >> > > diff --git a/refs/files-backend.c b/refs/files-backend.c >> > > index a9a066dcfb..252f835bae 100644 >> > > --- a/refs/files-backend.c >> > > +++ b/refs/files-backend.c >> > > @@ -1587,7 +1587,7 @@ static int log_ref_write_fd(int fd, const struct >> > > object_id *

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-09 Thread Brandon Williams
On 07/09, Stefan Beller wrote: > On Mon, Jul 9, 2018 at 6:09 AM Derrick Stolee wrote: > > > > On 7/8/2018 7:36 PM, brian m. carlson wrote: > > > 100 bytes is not sufficient to ensure we can write a commit message > > > buffer when using a 32-byte hash algorithm. Increase the buffer size to > > >

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-09 Thread Stefan Beller
On Mon, Jul 9, 2018 at 6:09 AM Derrick Stolee wrote: > > On 7/8/2018 7:36 PM, brian m. carlson wrote: > > 100 bytes is not sufficient to ensure we can write a commit message > > buffer when using a 32-byte hash algorithm. Increase the buffer size to > > ensure we have sufficient space. > > > > Si

Re: [PATCH 07/17] commit: increase commit message buffer size

2018-07-09 Thread Derrick Stolee
On 7/8/2018 7:36 PM, brian m. carlson wrote: 100 bytes is not sufficient to ensure we can write a commit message buffer when using a 32-byte hash algorithm. Increase the buffer size to ensure we have sufficient space. Signed-off-by: brian m. carlson --- refs/files-backend.c | 2 +- 1 file c

[PATCH 07/17] commit: increase commit message buffer size

2018-07-08 Thread brian m. carlson
100 bytes is not sufficient to ensure we can write a commit message buffer when using a 32-byte hash algorithm. Increase the buffer size to ensure we have sufficient space. Signed-off-by: brian m. carlson --- refs/files-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git