Re: [PATCH 07/16] compat: add endinanness helpers

2013-06-26 Thread Peter Krefting
Vicent Martí: I'm aware of that, but Git needs to build with glibc 2.7+ (or was it 2.6?), hence the need for this compat layer. Right. But perhaps the compatibility layer could provide the functionality with the names available in the later glibc versions (and on *BSD)? That would make it ea

Re: [PATCH 07/16] compat: add endinanness helpers

2013-06-25 Thread Vicent Martí
On Tue, Jun 25, 2013 at 3:08 PM, Peter Krefting wrote: > endian(3) claims that glibc 2.9+ define be64toh() and htobe64() which should > do what you are looking for. The manual page does mention them being named > differently across OSes, though, so you may need to be careful with that. I'm aware

Re: [PATCH 07/16] compat: add endinanness helpers

2013-06-25 Thread Peter Krefting
Vicent Marti: The POSIX standard doesn't currently define a `nothll`/`htonll` function pair to perform network-to-host and host-to-network swaps of 64-bit data. These 64-bit swaps are necessary for the on-disk storage of EWAH bitmaps if they are not in native byte order. endian(3) claims tha

[PATCH 07/16] compat: add endinanness helpers

2013-06-24 Thread Vicent Marti
The POSIX standard doesn't currently define a `nothll`/`htonll` function pair to perform network-to-host and host-to-network swaps of 64-bit data. These 64-bit swaps are necessary for the on-disk storage of EWAH bitmaps if they are not in native byte order. --- git-compat-util.h | 28 +++