Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

2013-04-04 Thread Junio C Hamano
Felipe Contreras writes: > I saw that you update the commit message without consulting here first to: > > --- > remote-hg: redirect unnecessary mercurial output > > Mercurial emits messages like "searching for changes", "no changes > found", etc. meant for the use of its own UI layer, which

Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

2013-04-04 Thread Felipe Contreras
Junio C Hamano wrote: > Felipe Contreras writes: > > > On Tue, Apr 2, 2013 at 1:58 PM, Junio C Hamano wrote: > >> Felipe Contreras writes: > >> > >>> We can't use stdout for that in remote helpers. > >>> > >>> Signed-off-by: Felipe Contreras > >>> --- > >> > >> You may want to clarify "buggy o

Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

2013-04-02 Thread Junio C Hamano
Felipe Contreras writes: > On Tue, Apr 2, 2013 at 1:58 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> We can't use stdout for that in remote helpers. >>> >>> Signed-off-by: Felipe Contreras >>> --- >> >> You may want to clarify "buggy output" a bit. Will mercurial >> forever be

Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

2013-04-02 Thread Felipe Contreras
On Tue, Apr 2, 2013 at 1:58 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> We can't use stdout for that in remote helpers. >> >> Signed-off-by: Felipe Contreras >> --- > > You may want to clarify "buggy output" a bit. Will mercurial > forever be broken? Some versions of Hg emit [[[i

Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

2013-04-02 Thread Junio C Hamano
Felipe Contreras writes: > We can't use stdout for that in remote helpers. > > Signed-off-by: Felipe Contreras > --- You may want to clarify "buggy output" a bit. Will mercurial forever be broken? Some versions of Hg emit [[[it is unclear for Junio to tell what it is to fill this blank]]] to

[PATCH 07/13] remote-hg: redirect buggy mercurial output

2013-04-02 Thread Felipe Contreras
We can't use stdout for that in remote helpers. Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-hg | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index b200e60..874ccd4 100755 --- a/contrib/re