[PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings

2014-04-29 Thread Marat Radchenko
HAVE_LIBCHARSET_H and NO_R_TO_GCC_LINKER are not specific to msysGit, they're general MinGW settings. Logic behind HAVE_LIBCHARSET_H: if user is on MinGW and has iconv, we expect him to have libcharset.h. If user doesn't have iconv, he has to explicitly say so via NO_ICONV=1. Signed-off-by: Marat

Re: [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings

2014-04-28 Thread Marat Radchenko
On Mon, Apr 28, 2014 at 05:17:25PM +0200, Erik Faye-Lund wrote: > > 1. What are other ways to provide iconv on MinGW? > > I'm not sure I understand. To set HAVE_LIBCHARSET_H, we need to have > libcharset.h. MinGW doesn't supply by default to my knowledge, so we > get it from iconv. The THIS_IS_MSY

Re: [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 5:04 PM, Marat Radchenko wrote: > On Mon, Apr 28, 2014 at 04:58:11PM +0200, Erik Faye-Lund wrote: >> On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko >> wrote: >> > HAVE_LIBCHARSET_H and NO_R_TO_GCC_LINKER are not specific to >> > msysGit, they're general MinGW settings.

Re: [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings

2014-04-28 Thread Marat Radchenko
On Mon, Apr 28, 2014 at 04:58:11PM +0200, Erik Faye-Lund wrote: > On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko > wrote: > > HAVE_LIBCHARSET_H and NO_R_TO_GCC_LINKER are not specific to > > msysGit, they're general MinGW settings. > > Actually, HAVE_LIBCHARSET_H is. It's only present because

Re: [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko wrote: > HAVE_LIBCHARSET_H and NO_R_TO_GCC_LINKER are not specific to > msysGit, they're general MinGW settings. Actually, HAVE_LIBCHARSET_H is. It's only present because we have libiconv installed. -- To unsubscribe from this list: send the line "

[PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings

2014-04-28 Thread Marat Radchenko
HAVE_LIBCHARSET_H and NO_R_TO_GCC_LINKER are not specific to msysGit, they're general MinGW settings. Signed-off-by: Marat Radchenko --- config.mak.uname | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config.mak.uname b/config.mak.uname index dc87e21..2f1939e 100644 ---