Re: [PATCH 06/26] mailinfo: always pass "line" as an argument

2015-10-14 Thread Junio C Hamano
Stefan Beller writes: >> @@ -1019,10 +1019,10 @@ static int mailinfo(FILE *in, FILE *out, const char >> *msg, const char *patch) >> ungetc(peek, in); >> >> /* process the email header */ >> - while (read_one_header_line(&line, fin)) >> - check_header(&line, p_

Re: [PATCH 06/26] mailinfo: always pass "line" as an argument

2015-10-14 Thread Stefan Beller
On Tue, Oct 13, 2015 at 4:16 PM, Junio C Hamano wrote: > Some functions in this module accessed the global "struct strbuf > line" while many others used a strbuf passed as an argument. > Convert the former to ensure that nobody deeper in the callchains > relies on the global one. > > Signed-off-by

[PATCH 06/26] mailinfo: always pass "line" as an argument

2015-10-13 Thread Junio C Hamano
Some functions in this module accessed the global "struct strbuf line" while many others used a strbuf passed as an argument. Convert the former to ensure that nobody deeper in the callchains relies on the global one. Signed-off-by: Junio C Hamano --- builtin/mailinfo.c | 48