Re: [PATCH 06/23] midx: struct midxed_git and 'read' subcommand

2018-06-20 Thread Derrick Stolee
On 6/20/2018 11:07 AM, Duy Nguyen wrote: On Wed, Jun 20, 2018 at 3:33 PM Derrick Stolee wrote: On 6/7/2018 2:31 PM, Duy Nguyen wrote: On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: diff --git a/Documentation/git-midx.txt b/Documentation/git-midx.txt index dcaeb1a91b..919283fdd8 100644

Re: [PATCH 06/23] midx: struct midxed_git and 'read' subcommand

2018-06-20 Thread Duy Nguyen
On Wed, Jun 20, 2018 at 3:33 PM Derrick Stolee wrote: > > On 6/7/2018 2:31 PM, Duy Nguyen wrote: > > On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: > >> diff --git a/Documentation/git-midx.txt b/Documentation/git-midx.txt > >> index dcaeb1a91b..919283fdd8 100644 > >> --- a/Documentation/gi

Re: [PATCH 06/23] midx: struct midxed_git and 'read' subcommand

2018-06-20 Thread Derrick Stolee
On 6/7/2018 2:31 PM, Duy Nguyen wrote: On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: diff --git a/Documentation/git-midx.txt b/Documentation/git-midx.txt index dcaeb1a91b..919283fdd8 100644 --- a/Documentation/git-midx.txt +++ b/Documentation/git-midx.txt @@ -23,6 +23,11 @@ OPTIONS

Re: [PATCH 06/23] midx: struct midxed_git and 'read' subcommand

2018-06-20 Thread Derrick Stolee
On 6/7/2018 1:54 PM, Duy Nguyen wrote: On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: As we build the multi-pack-index feature by adding chunks at a time, we want to test that the data is being written correctly. Create struct midxed_git to store an in-memory representation of a A word

Re: [PATCH 06/23] midx: struct midxed_git and 'read' subcommand

2018-06-07 Thread Duy Nguyen
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: > diff --git a/Documentation/git-midx.txt b/Documentation/git-midx.txt > index dcaeb1a91b..919283fdd8 100644 > --- a/Documentation/git-midx.txt > +++ b/Documentation/git-midx.txt > @@ -23,6 +23,11 @@ OPTIONS > /packs/multi-pack-index fo

Re: [PATCH 06/23] midx: struct midxed_git and 'read' subcommand

2018-06-07 Thread Duy Nguyen
On Thu, Jun 7, 2018 at 4:03 PM, Derrick Stolee wrote: > As we build the multi-pack-index feature by adding chunks at a time, > we want to test that the data is being written correctly. > > Create struct midxed_git to store an in-memory representation of a A word play on 'packed_git'? Amusing. Som

[PATCH 06/23] midx: struct midxed_git and 'read' subcommand

2018-06-07 Thread Derrick Stolee
As we build the multi-pack-index feature by adding chunks at a time, we want to test that the data is being written correctly. Create struct midxed_git to store an in-memory representation of a multi-pack-index and a memory-map of the binary file. Initialize this struct in load_midxed_git(object_d