Re: [PATCH 06/11] submodule.c: sort changed_submodule_names before searching it

2018-09-11 Thread Stefan Beller
On Thu, Sep 6, 2018 at 11:03 AM Junio C Hamano wrote: > > Stefan Beller writes: > > > Instead of sorting it after we created an unsorted list, we could insert > > correctly into the list. > > It is unclear what problem you are solving, especially with > subjunctive "could" there. We are creating

Re: [PATCH 06/11] submodule.c: sort changed_submodule_names before searching it

2018-09-06 Thread Junio C Hamano
Stefan Beller writes: > Instead of sorting it after we created an unsorted list, we could insert > correctly into the list. It is unclear what problem you are solving, especially with subjunctive "could" there. We are creating an unsorted list and then sorting it and you see it as a problem bec

[PATCH 06/11] submodule.c: sort changed_submodule_names before searching it

2018-09-04 Thread Stefan Beller
Instead of sorting it after we created an unsorted list, we could insert correctly into the list. As the unsorted append is in order of cache entry names, this is already sorted if names were equal to paths for submodules. As submodule names are often the same as their path, the input is sorted p