Re: [PATCH 05/20] rename_tmp_log(): use raceproof_create_file()

2016-02-19 Thread Junio C Hamano
Michael Haggerty writes: > Now, we have to consider the opposite case, namely that we are calling a > non-buggy implementation of `rename()`, and we artificially change > ENOTDIR to EISDIR. Can that cause any bad effects? > > I don't think so, because the case where a non-buggy implementation can

Re: [PATCH 05/20] rename_tmp_log(): use raceproof_create_file()

2016-02-19 Thread Michael Haggerty
On 02/17/2016 09:53 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> Besides shortening the code, this saves an unnecessary call to >> safe_create_leading_directories_const() in almost all cases. >> >> Signed-off-by: Michael Haggerty >> --- >> refs/files-backend.c | 76 >>

Re: [PATCH 05/20] rename_tmp_log(): use raceproof_create_file()

2016-02-17 Thread Junio C Hamano
Michael Haggerty writes: > Besides shortening the code, this saves an unnecessary call to > safe_create_leading_directories_const() in almost all cases. > > Signed-off-by: Michael Haggerty > --- > refs/files-backend.c | 76 > ++-- > 1 file change

[PATCH 05/20] rename_tmp_log(): use raceproof_create_file()

2016-02-16 Thread Michael Haggerty
Besides shortening the code, this saves an unnecessary call to safe_create_leading_directories_const() in almost all cases. Signed-off-by: Michael Haggerty --- refs/files-backend.c | 76 ++-- 1 file changed, 32 insertions(+), 44 deletions(-) diff